Publish app shortcuts on Mac

chrome/app/app_mode_loader_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // On Mac, shortcuts can't have command-line arguments. Instead, produce small
 // app bundles which locate the Chromium framework and load it, passing the
 // appropriate data. This is the code for such an app bundle. It should be kept
 // minimal and do as little work as possible (with as much work done on
 // framework side as possible).
 
@@ skipping 48 matching lines @@
   // The Cocoa APIs are a bit more convenient; for this an autorelease pool is
   // needed.
   NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
 
   // Get the current main bundle, i.e., that of the app loader that's running.
   NSBundle* app_bundle = [NSBundle mainBundle];
   CHECK_MSG(app_bundle, "couldn't get loader bundle");
 
   // Get the bundle ID of the browser that created this app bundle.
   NSString* cr_bundle_id = [app_bundle
-      objectForInfoDictionaryKey:(NSString*)app_mode::kBrowserBundleIDKey];
+      objectForInfoDictionaryKey:app_mode::kBrowserBundleIDKey];
   CHECK_MSG(cr_bundle_id, "couldn't get browser bundle ID");
 
   // Get the browser bundle path.
   // TODO(viettrungluu): more fun
-  NSString* cr_bundle_path =
-      [(NSString*)CFPreferencesCopyAppValue(
-          app_mode::kLastRunAppBundlePathPrefsKey,
-          (CFStringRef)cr_bundle_id) autorelease];
+  NSString* cr_bundle_path = [(NSString*)CFPreferencesCopyAppValue(

[---DO-NOT-USE---rsesek1, 2012/02/08 12:24:33]

You could fix these up to use the NSToCFCast and CFToNSCast functions.

[sail, 2012/02/08 19:09:15]

Currently this code doesn't use base/*. This is fixed in jeremy's CL.

+      (CFStringRef)app_mode::kLastRunAppBundlePathPrefsKey,
+      (CFStringRef)cr_bundle_id) autorelease];
   CHECK_MSG(cr_bundle_path, "couldn't get browser bundle path");
 
   // Get the browser bundle.
   NSBundle* cr_bundle = [NSBundle bundleWithPath:cr_bundle_path];
   CHECK_MSG(cr_bundle, "couldn't get browser bundle");
 
   // Get the current browser version.
   NSString* cr_version =
       [cr_bundle objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
   CHECK_MSG(cr_version, "couldn't get browser version");
@@ skipping 14 matching lines @@
 
   // Optional, so okay if it's NULL.
   info.app_mode_bundle_path = NSStringToFSCString([app_bundle bundlePath]);
 
   // Read information about the this app shortcut from the Info.plist.
   // Don't check for null-ness on optional items.
   NSDictionary* info_plist = [app_bundle infoDictionary];
   CHECK_MSG(info_plist, "couldn't get loader Info.plist");
 
   info.app_mode_id = NSStringToUTF8CString(
-      [info_plist objectForKey:@"CrAppModeShortcutID"]);
+      [info_plist objectForKey:app_mode::kCrAppModeShortcutIDKey]);
   CHECK_MSG(info.app_mode_id, "couldn't get app shortcut ID");
 
   info.app_mode_short_name = NSStringToUTF8CString(
-      [info_plist objectForKey:@"CrAppModeShortcutShortName"]);
+      [info_plist objectForKey:app_mode::kCrAppModeShortcutShortNameKey]);
 
   info.app_mode_name = NSStringToUTF8CString(
-      [info_plist objectForKey:@"CrAppModeShortcutName"]);
+      [info_plist objectForKey:app_mode::kCrAppModeShortcutNameKey]);
 
   info.app_mode_url = NSStringToUTF8CString(
-      [info_plist objectForKey:@"CrAppModeShortcutURL"]);
+      [info_plist objectForKey:app_mode::kCrAppModeShortcutURLKey]);
   CHECK_MSG(info.app_mode_url, "couldn't get app shortcut URL");
 
   // Get the framework path.
   NSString* cr_bundle_exe =
       [cr_bundle objectForInfoDictionaryKey:@"CFBundleExecutable"];
   NSString* cr_framework_path =
       [cr_versioned_path stringByAppendingPathComponent:
           [cr_bundle_exe stringByAppendingString:@" Framework.framework"]];
   cr_framework_path =
       [cr_framework_path stringByAppendingPathComponent:
           [cr_bundle_exe stringByAppendingString:@" Framework"]];
 
   // Open the framework.
   void* cr_dylib = dlopen([cr_framework_path fileSystemRepresentation],
                           RTLD_LAZY);
   CHECK_MSG(cr_dylib, "couldn't load framework");
 
   // Drain the pool as late as possible.
   [pool drain];
 
   typedef int (*StartFun)(const app_mode::ChromeAppModeInfo*);
   StartFun ChromeAppModeStart = (StartFun)dlsym(cr_dylib, "ChromeAppModeStart");
   CHECK_MSG(ChromeAppModeStart, "couldn't get entry point");
 
   // Exit instead of returning to avoid the the removal of |main()| from stack
   // backtraces under tail call optimization.
   int rv = ChromeAppModeStart(&info);
   exit(rv);
 }