Publish app shortcuts on Mac

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 2617 matching lines @@
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }
 
 void ExtensionService::StartInstallApplicationShortcut(
     const Extension* extension) {
-#if !defined(OS_MACOSX)
+#if defined(OS_MACOSX)
+  // TODO(sail): For now only install shortcuts for if enable platform apps

[Mark Mentovai, 2012/02/08 05:53:26]

Revise grammar (get rid of “for?”)

[sail, 2012/02/08 06:12:51]

Done.

+  // is true and if the extension is a platform app.
+  if (!extension->is_platform_app() ||
+      !CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnablePlatformApps)) {
+    return;
+  }
+#endif
+
   const int kAppIconSize = 32;
 
   shortcut_info_.extension_id = extension->id();
   shortcut_info_.url = GURL(extension->launch_web_url());
   shortcut_info_.title = UTF8ToUTF16(extension->name());
   shortcut_info_.description = UTF8ToUTF16(extension->description());
   shortcut_info_.create_in_applications_menu = true;
   shortcut_info_.create_in_quick_launch_bar = true;
   shortcut_info_.create_on_desktop = true;
 
@@ skipping 15 matching lines @@
         ExtensionIconSet::MATCH_SMALLER);
   }
 
   // icon_resource may still be empty at this point, in which case LoadImage
   // which call the OnImageLoaded callback with a NULL image and exit
   // immediately.
   tracker_.LoadImage(extension,
                      icon_resource,
                      max_size,
                      ImageLoadingTracker::DONT_CACHE);
-#endif
 }
 
 void ExtensionService::OnImageLoaded(SkBitmap *image,
                                      const ExtensionResource &resource,
                                      int index) {
   // If the image failed to load (e.g. if the resource being loaded was empty)
   // use the standard application icon.
   if (!image || image->isNull())
     image = ExtensionIconSource::LoadImageByResourceId(IDR_APP_DEFAULT_ICON);
 
   shortcut_info_.favicon = *image;
   web_app::CreateShortcut(profile_->GetPath(), shortcut_info_);
 }
 
 extensions::SocketController* ExtensionService::socket_controller() {
   // TODO(miket): Find a better place for SocketController to live. It needs
   // to be scoped such that it can be created and destroyed on the IO thread.
   //
   // To coexist with certain unit tests that don't have an IO thread message
   // loop available at ExtensionService shutdown, we lazy-initialize this
   // object so that those cases neither create nor destroy a SocketController.
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (!socket_controller_) {
     socket_controller_ = new extensions::SocketController();
   }
   return socket_controller_;
 }