Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: client/dom/scripts/dartgenerator.py

Issue 9346008: Remove vestigial constructors in Frog implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/generated/src/frog/XMLHttpRequest.dart ('k') | client/dom/src/_FactoryProviders.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartgenerator.py
diff --git a/client/dom/scripts/dartgenerator.py b/client/dom/scripts/dartgenerator.py
index 44e671ea586fcc4fc7e14e29c66a274f232091c9..c2408f40caa405a1afe7ef7b197dd21ddc004349 100755
--- a/client/dom/scripts/dartgenerator.py
+++ b/client/dom/scripts/dartgenerator.py
@@ -66,24 +66,6 @@ _dart_to_idl_type_conversions = dict((v,k) for k, v in
_javascript_keywords = ['delete', 'continue']
#
-# Types with user-invocable constructors. We do not have enough
-# information in IDL to create the signature.
-#
-# Each entry is of the form:
-# type name: constructor parameters
-_constructable_types = {
- 'AudioContext': '',
- 'FileReader': '',
- 'XMLHttpRequest': '',
- 'WebKitCSSMatrix': '[String spec]',
- 'WebKitPoint': 'num x, num y',
- 'WebSocket': 'String url',
- # dart:html types
- 'CSSMatrix': '[String spec]',
- 'Point': 'num x, num y',
-}
-
-#
# Interface version of the DOM needs to delegate typed array constructors to a
# factory provider.
#
@@ -1932,12 +1914,6 @@ class FrogInterfaceGenerator(object):
IMPLEMENTS=' implements ' + ', '.join(implements),
NATIVESPEC=' native "' + native_spec + '"')
- if interface_name in _constructable_types:
- self._members_emitter.Emit(
- ' $NAME($PARAMS) native;\n\n',
- NAME=interface_name,
- PARAMS=_constructable_types[interface_name])
-
element_type = MaybeTypedArrayElementType(interface)
if element_type:
self.AddTypedArrayConstructors(element_type)
« no previous file with comments | « client/dom/generated/src/frog/XMLHttpRequest.dart ('k') | client/dom/src/_FactoryProviders.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698