Issue 9344003: Fix re-entrancy bug in SimpleDataSource::Abort() introduced in r118338.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9344003: Fix re-entrancy bug in SimpleDataSource::Abort() introduced in r118338. (Closed)

Created:
8 years, 10 months ago by Ami GONE FROM CHROMIUM

Modified:
8 years, 10 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromiu.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org, acolwell GONE FROM CHROMIUM

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix re-entrancy bug in SimpleDataSource::Abort() introduced in r118338. BUG=112180 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120714

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -14 lines)			Patch
M	webkit/media/simple_data_source.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/media/simple_data_source.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	webkit/media/simple_data_source_unittest.cc	View	10 chunks	+29 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

haha I was mid-CL-writing to handle this LGTM

8 years, 10 months ago (2012-02-06 22:13:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9344003/1

8 years, 10 months ago (2012-02-06 22:18:14 UTC) #3

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

8 years, 10 months ago (2012-02-07 00:17:46 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-07 01:06:57 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/9344003/1

Expand Messages | Collapse Messages