Introduce AudioRendererAlgorithmBase::VerifyConfig.

media/filters/audio_renderer_algorithm_base.cc

Index: media/filters/audio_renderer_algorithm_base.cc
diff --git a/media/filters/audio_renderer_algorithm_base.cc b/media/filters/audio_renderer_algorithm_base.cc
index 8bc742de683078c4eab36776ee8db8577e323df7..57c239280c792eeb214317713171df243006038f 100644
--- a/media/filters/audio_renderer_algorithm_base.cc
+++ b/media/filters/audio_renderer_algorithm_base.cc
@@ -47,21 +47,41 @@ AudioRendererAlgorithmBase::AudioRendererAlgorithmBase()
 
 AudioRendererAlgorithmBase::~AudioRendererAlgorithmBase() {}
 
+bool AudioRendererAlgorithmBase::VerifyConfig(
+    int channels,
+    int samples_per_second,
+    int bits_per_channel,
+    float initial_playback_rate) {

[Ami GONE FROM CHROMIUM, 2012/02/07 21:08:42]

i_p_r is not inspected.  Intentional?

[DaleCurtis, 2012/02/07 22:48:03]

Yup, there was no check before, so I didn't add one. I left the parameter since
this would be the place to add one in the future though.

[Ami GONE FROM CHROMIUM, 2012/02/07 23:00:11]

YAGNI principle says drop it now, add it later, if needed.
(later usually never comes)

[DaleCurtis, 2012/02/08 00:09:43]

Done.

+  bool status = true;
+
+  if (channels <= 0 || channels > 8) {
+    DLOG(ERROR) << "We only support audio with between 1 and 8 channels.";
+    status = false;
+  }
+
+  if (samples_per_second <= 0 || samples_per_second > 256000) {
+    DLOG(ERROR) << "We only support sample rates between 1 and 256000Hz.";
+    status = false;
+  }
+
+  if (bits_per_channel != 8 && bits_per_channel != 16 &&
+      bits_per_channel != 32) {
+    DLOG(ERROR) << "We only support 8, 16, 32 bit audio.";
+    status = false;
+  }
+
+  return status;
+}
+
 void AudioRendererAlgorithmBase::Initialize(
     int channels,
     int samples_per_second,
     int bits_per_channel,
     float initial_playback_rate,
     const base::Closure& callback) {
-  DCHECK_GT(channels, 0);
-  DCHECK_LE(channels, 8) << "We only support <= 8 channel audio.";
-  DCHECK_GT(samples_per_second, 0);
-  DCHECK_LE(samples_per_second, 256000)
-      << "We only support sample rates at or below 256000Hz.";
-  DCHECK_GT(bits_per_channel, 0);
-  DCHECK_LE(bits_per_channel, 32) << "We only support 8, 16, 32 bit audio.";
-  DCHECK_EQ(bits_per_channel % 8, 0) << "We only support 8, 16, 32 bit audio.";
   DCHECK(!callback.is_null());
+  DCHECK(VerifyConfig(channels, samples_per_second, bits_per_channel,
+                      initial_playback_rate));
 
   channels_ = channels;
   samples_per_second_ = samples_per_second;