Introduce AudioRendererAlgorithmBase::VerifyConfig.

As titled, provides a way to check the audio config prior to Initialize so that DCHECKs are not hit.

BUG=none
TEST=Played video which should dcheck, observed error instead.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121182

[DaleCurtis, 2012-02-07 20:48:52]

+fischman

PTAL, reworked to use fischman's suggestion of non-bool Initialize.

[Ami GONE FROM CHROMIUM, 2012-02-07 21:08:42]

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
File media/filters/audio_renderer_algorithm_base.cc (right):

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.cc:54: float initial_playback_rate)
{
i_p_r is not inspected.  Intentional?

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
File media/filters/audio_renderer_algorithm_base.h (right):

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.h:40: bool VerifyConfig(int
channels,
static

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.h:40: bool VerifyConfig(int
channels,
s/Verify/Validate/

[DaleCurtis, 2012-02-07 22:48:02]

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
File media/filters/audio_renderer_algorithm_base.cc (right):

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.cc:54: float initial_playback_rate)
{
On 2012/02/07 21:08:42, Ami Fischman wrote:
> i_p_r is not inspected.  Intentional?

Yup, there was no check before, so I didn't add one. I left the parameter since
this would be the place to add one in the future though.

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
File media/filters/audio_renderer_algorithm_base.h (right):

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.h:40: bool VerifyConfig(int
channels,
On 2012/02/07 21:08:42, Ami Fischman wrote:
> static

Done.

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.h:40: bool VerifyConfig(int
channels,
On 2012/02/07 21:08:42, Ami Fischman wrote:
> s/Verify/Validate/

Done.

[Ami GONE FROM CHROMIUM, 2012-02-07 23:00:11]

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
File media/filters/audio_renderer_algorithm_base.cc (right):

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.cc:54: float initial_playback_rate)
{
On 2012/02/07 22:48:03, DaleCurtis wrote:
> On 2012/02/07 21:08:42, Ami Fischman wrote:
> > i_p_r is not inspected.  Intentional?
> 
> Yup, there was no check before, so I didn't add one. I left the parameter
since
> this would be the place to add one in the future though.

YAGNI principle says drop it now, add it later, if needed.
(later usually never comes)

[DaleCurtis, 2012-02-08 00:09:42]

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
File media/filters/audio_renderer_algorithm_base.cc (right):

https://chromiumcodereview.appspot.com/9344002/diff/8001/media/filters/audio_...
media/filters/audio_renderer_algorithm_base.cc:54: float initial_playback_rate)
{
On 2012/02/07 23:00:11, Ami Fischman wrote:
> On 2012/02/07 22:48:03, DaleCurtis wrote:
> > On 2012/02/07 21:08:42, Ami Fischman wrote:
> > > i_p_r is not inspected.  Intentional?
> > 
> > Yup, there was no check before, so I didn't add one. I left the parameter
> since
> > this would be the place to add one in the future though.
> 
> YAGNI principle says drop it now, add it later, if needed.
> (later usually never comes)

Done.

[Ami GONE FROM CHROMIUM, 2012-02-09 00:00:28]

LGTM % nits

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
File media/filters/audio_renderer_algorithm_base.cc (right):

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
media/filters/audio_renderer_algorithm_base.cc:57: DLOG(ERROR) << "We only
support audio with between 1 and 8 channels.";
s/DLOG/DVLOG/ here and below.

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
File media/filters/audio_renderer_algorithm_base.h (right):

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
media/filters/audio_renderer_algorithm_base.h:39: // configuration is invalid. 
Detailed error information will be DLOG'd.
s/DLOG/DVLOG/

[DaleCurtis, 2012-02-09 02:21:32]

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
File media/filters/audio_renderer_algorithm_base.cc (right):

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
media/filters/audio_renderer_algorithm_base.cc:57: DLOG(ERROR) << "We only
support audio with between 1 and 8 channels.";
On 2012/02/09 00:00:28, Ami Fischman wrote:
> s/DLOG/DVLOG/ here and below.

Done.

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
File media/filters/audio_renderer_algorithm_base.h (right):

https://chromiumcodereview.appspot.com/9344002/diff/15002/media/filters/audio...
media/filters/audio_renderer_algorithm_base.h:39: // configuration is invalid. 
Detailed error information will be DLOG'd.
On 2012/02/09 00:00:28, Ami Fischman wrote:
> s/DLOG/DVLOG/

Done.

[commit-bot: I haz the power, 2012-02-09 02:21:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/9344002/21004

[commit-bot: I haz the power, 2012-02-09 03:57:36]

Change committed as 121182