Issue 9343001: The Chromium and Google Chrome builds of the chromoting webapp use different

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9343001: The Chromium and Google Chrome builds of the chromoting webapp use different (Closed)

Created:
8 years, 10 months ago by simonmorris

Modified:
8 years, 10 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

The Chromium and Google Chrome builds of the chromoting webapp use different keys to access Google services. BUG=112889 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120782

Patch Set 1 #

Patch Set 2 : Move buildtype-dependent parameters to plugin_settings.js." #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
M	remoting/webapp/build-webapp.py	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	remoting/webapp/oauth2.js	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	remoting/webapp/plugin_settings.js	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

We try to confine all compile-time substitutions to plugin-settings.js. Since there's already some OAuth stuff ...

8 years, 10 months ago (2012-02-06 21:26:18 UTC) #2

simonmorris

On 2012/02/06 21:26:18, Jamie wrote: > We try to confine all compile-time substitutions to plugin-settings.js. ...

8 years, 10 months ago (2012-02-06 21:49:39 UTC) #3

lgtm

Expand Messages | Collapse Messages