Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 9342008: start of code to generate dart:html using dart:dom scripts (Closed)

Created:
8 years, 10 months ago by Jennifer Messerly
Modified:
8 years, 10 months ago
Reviewers:
Jacob, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

This change is the start of code to generate dart:html using dart:dom scripts. It essentially just adds the scaffolding for dart:html, and implements the generation of the "Events" interface and "EventsImpl" classes. There's more to do before the result is actually usable. For example, this doesn't contain EventsImplementation--I'm assuming we'll take jacobr's handwritten version. I didn't check in the ../generated/html folder yet, but let me know if that makes sense. (Note: I started with a copy of DartInterfaceGenerator instead of inheriting, but it ended up causing extra duplication when merging Stephen's recent getter/setter change. I think inheritance will be an easier way to build up the functionality, because we're essentially saying "dart:html is like dart:dom, but apply these extra transforms". Once most of the methods are overridden it would definitely make sense to break the link.) Committed: https://code.google.com/p/dart/source/detail?r=4021

Patch Set 1 #

Patch Set 2 : merged #

Total comments: 10

Patch Set 3 : cr feedback #

Patch Set 4 : removed html_frog #

Patch Set 5 : merged #

Patch Set 6 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -78 lines) Patch
M client/dom/scripts/dartdomgenerator.py View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 2 3 4 5 13 chunks +195 lines, -8 lines 0 comments Download
D client/dom/templates/dom/frog/frog_impl.darttemplate View 1 chunk +0 lines, -3 lines 0 comments Download
D client/dom/templates/dom/frog/immutable_list_mixin.darttemplate View 1 chunk +0 lines, -67 lines 0 comments Download
A + client/dom/templates/frog_impl.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
A client/dom/templates/html/frog/html_frog.darttemplate View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A client/dom/templates/html/frog/impl_Console.darttemplate View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + client/dom/templates/immutable_list_mixin.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jennifer Messerly
Hey guys, let me know what the next steps are from here. Cheers!
8 years, 10 months ago (2012-02-07 03:42:30 UTC) #1
sra1
Looks OK as a work in progress. No need to check in the results yet. ...
8 years, 10 months ago (2012-02-07 05:06:16 UTC) #2
Jacob
https://chromiumcodereview.appspot.com/9342008/diff/2001/client/dom/templates/html/frog/impl_Console.darttemplate File client/dom/templates/html/frog/impl_Console.darttemplate (right): https://chromiumcodereview.appspot.com/9342008/diff/2001/client/dom/templates/html/frog/impl_Console.darttemplate#newcode14 client/dom/templates/html/frog/impl_Console.darttemplate:14: var dartObjectLocalStorage; dartObjectLocalStorage and typeName as not needed. https://chromiumcodereview.appspot.com/9342008/diff/2001/client/dom/templates/html/frog/impl_Storage.darttemplate ...
8 years, 10 months ago (2012-02-07 18:58:03 UTC) #3
Jennifer Messerly
PTAL @sra - how do you guys build the combined dart:dom today? I could look ...
8 years, 10 months ago (2012-02-07 21:05:14 UTC) #4
Jacob
lgtm
8 years, 10 months ago (2012-02-07 21:08:39 UTC) #5
Jennifer Messerly
8 years, 10 months ago (2012-02-08 01:12:33 UTC) #6
On 2012/02/07 21:08:39, Jacob wrote:
> lgtm

Thanks. Sounds like we want to check in and keep hacking. I'll submit.

Powered by Google App Engine
This is Rietveld 408576698