Use 'field' syntax in dart:dom interfaces.

client/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 1232 matching lines @@
         self._interface.id is self._super_interface):
       self._EmitConstant(self._members_emitter, constant)
 
   def _EmitConstant(self, emitter, constant):
     emitter.Emit('\n  static final $TYPE $NAME = $VALUE;\n',
                  NAME=constant.id,
                  TYPE=constant.type.id,
                  VALUE=constant.value)
 
   def AddAttribute(self, getter, setter):
-    if getter:
-      self._members_emitter.Emit('\n  $TYPE get $NAME();\n',
-                                 NAME=getter.id, TYPE=getter.type.id)
-    if setter:
-      self._members_emitter.Emit('\n  void set $NAME($TYPE value);\n',
-                                 NAME=setter.id, TYPE=setter.type.id)
+    if getter and setter and getter.type.id == setter.type.id:
+      self._members_emitter.Emit('\n  $TYPE $NAME;\n',
+                                 NAME=getter.id, TYPE=getter.type.id);
+      return
+    if getter and not setter:
+      self._members_emitter.Emit('\n  final $TYPE $NAME;\n',
+                                 NAME=getter.id, TYPE=getter.type.id);
+      return
+    raise Exception('Unexpected getter/setter combination %s %s' %
+                    (getter, setter))
 
   def AddIndexer(self, element_type):
     # Interface inherits all operations from List<element_type>.
     pass
 
   def AddOperation(self, info):
     """
     Arguments:
       operations - contains the overloads, one or more operations with the same
         name.
@@ skipping 702 matching lines @@
     # generate the constants as part of the class.  This will need to go away
     # if we revert back to generating interfaces.
     self._members_emitter.Emit('\n  static final $TYPE $NAME = $VALUE;\n',
                                NAME=constant.id,
                                TYPE=constant.type.id,
                                VALUE=constant.value)
 
     pass
 
   def AddAttribute(self, getter, setter):
-    use_fields = True
     output_type = getter and self._NarrowOutputType(getter.type.id)
     input_type = setter and self._NarrowInputType(setter.type.id)
-    if use_fields and getter and setter:
-      if input_type == output_type:
-        self._members_emitter.Emit(
-            '\n  $TYPE $NAME;\n',
-            NAME=getter.id, TYPE=output_type)
-        return
-    if use_fields and getter and not setter:
-        self._members_emitter.Emit(
-            '\n  final $TYPE $NAME;\n',
-            NAME=getter.id, TYPE=output_type)
-        return
+    if getter and setter and input_type == output_type:
+      self._members_emitter.Emit(
+          '\n  $TYPE $NAME;\n',
+          NAME=getter.id, TYPE=output_type)
+      return
+    if getter and not setter:
+      self._members_emitter.Emit(
+          '\n  final $TYPE $NAME;\n',
+          NAME=getter.id, TYPE=output_type)
+      return
     if getter:
       self._AddGetter(getter)
     if setter:
       self._AddSetter(setter)
 
   def _AddGetter(self, attr):
     # TODO(sra): Remove native body when Issue 829 fixed.
     self._members_emitter.Emit(
         '\n  $TYPE get $NAME() native "return this.$NAME;";\n',
         NAME=attr.id, TYPE=self._NarrowOutputType(attr.type.id))
@@ skipping 307 matching lines @@
                    INDENT=indent,
                    NATIVENAME=native_name,
                    ARGS=argument_expressions)
 
     self._members_emitter.Emit('  $TYPE $NATIVE_NAME($PARAMS) native '
                                '"$(INTERFACE)$(NATIVE_NAME)_Callback";\n',
                                NATIVE_NAME=native_name,
                                TYPE=info.type_name,
                                PARAMS=', '.join(arg_names),
                                INTERFACE=self._interface.id)