Issue 9341003: Change required for rolling-in skia change being reviewed here: http://codereview.appspot.com/562...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9341003: Change required for rolling-in skia change being reviewed here: http://codereview.appspot.com/562... (Closed)

Created:
8 years, 10 months ago by Justin Novosad

Modified:
8 years, 6 months ago

Reviewers:
epoger

CC:
reed1

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Change required for rolling-in skia change being reviewed here: http://codereview.appspot.com/5626047/

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
M	skia/ext/bitmap_platform_device_mac.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	skia/ext/bitmap_platform_device_win.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/bitmap_platform_device_win.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

epoger

LGTM Thanks for preparing this... I take it that this change must be committed to ...

8 years, 10 months ago (2012-02-06 22:01:16 UTC) #3

Justin Novosad

On 2012/02/06 22:01:16, epoger wrote: > LGTM > > Thanks for preparing this... > > ...

8 years, 10 months ago (2012-02-06 22:03:10 UTC) #4

Justin Novosad

Skia counterpart was committed as r3147. Rolling skia deps past r3147 will require this change

8 years, 10 months ago (2012-02-07 16:29:23 UTC) #5

epoger

8 years, 10 months ago (2012-02-07 17:08:02 UTC) #6

On 2012/02/07 16:29:23, junov wrote:
> Skia counterpart was committed as r3147.
> Rolling skia deps past r3147 will require this change

Thanks, Justin!  I have incorporated this patch into the DEPS roll at
https://chromiumcodereview.appspot.com/9346023/ .

Expand Messages | Collapse Messages