Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2151)

Unified Diff: chrome/browser/extensions/extension_sorting_unittest.cc

Issue 9340007: Make the Chrome Web Store Icon Syncable (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Removing braces Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sorting_unittest.cc
diff --git a/chrome/browser/extensions/extension_sorting_unittest.cc b/chrome/browser/extensions/extension_sorting_unittest.cc
index fb79ecf0fd2052f00324631163503abb2a502407..bef5499bb9b00a170b5dc0cd7fca8df50a408c02 100644
--- a/chrome/browser/extensions/extension_sorting_unittest.cc
+++ b/chrome/browser/extensions/extension_sorting_unittest.cc
@@ -520,13 +520,37 @@ class ExtensionSortingFixNTPCollisionsTwoCollisions
TEST_F(ExtensionSortingFixNTPCollisionsTwoCollisions,
ExtensionSortingFixNTPCollisionsTwoCollisions) {}
+class ExtensionSortingEnsureValidOrdinals :
+ public ExtensionPrefsPrepopulatedTest {
+ public :
+ ExtensionSortingEnsureValidOrdinals() {}
+ ~ExtensionSortingEnsureValidOrdinals() {}
+
+ virtual void Initialize() {}
+ virtual void Verify() {
+ ExtensionSorting* extension_sorting = prefs()->extension_sorting();
+
+ // Give ext1 invalid ordinals and then check that EnsureValidOridnals fixes
+ // them.
+ extension_sorting->SetAppLaunchOrdinal(ext1_->id(), StringOrdinal());
+ extension_sorting->SetPageOrdinal(ext1_->id(), StringOrdinal());
+
+ extension_sorting->EnsureValidOrdinals(ext1_->id());
+
+ EXPECT_TRUE(extension_sorting->GetAppLaunchOrdinal(ext1_->id()).IsValid());
+ EXPECT_TRUE(extension_sorting->GetPageOrdinal(ext1_->id()).IsValid());
+ }
+};
+TEST_F(ExtensionSortingEnsureValidOrdinals,
+ ExtensionSortingEnsureValidOrdinals) {}
+
class ExtensionSortingPageOrdinalMapping :
public ExtensionPrefsPrepopulatedTest {
public:
ExtensionSortingPageOrdinalMapping() {}
virtual ~ExtensionSortingPageOrdinalMapping() {}
- virtual void Initialize() {}
+ virtual void Initialize() {}
virtual void Verify() {
std::string ext_1 = "ext_1";
std::string ext_2 = "ext_2";
« no previous file with comments | « chrome/browser/extensions/extension_sorting.cc ('k') | chrome/browser/extensions/pending_extension_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698