Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: chrome/common/extensions/extension.cc

Issue 9340007: Make the Chrome Web Store Icon Syncable (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 04475081a52ddc8d892092fde25f1caeb48a4a19..32843c793fafd1d1bf9a51aa96b479b51059db9a 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -2971,6 +2971,13 @@ bool Extension::OverlapsWithOrigin(const GURL& origin) const {
}
Extension::SyncType Extension::GetSyncType() const {
+ // The CWS needs to be treated as syncable app because it appears on the NTP
+ // and we need to make sure its position values are synced.
+ // If another case arises where we need to have a special case like the CWS,
+ // something more systematically should be done.
Finnur 2012/02/07 10:12:53 s/systematically/systematic.
csharp 2012/02/07 15:49:41 Done.
+ if (id() == extension_misc::kWebStoreAppId)
+ return SYNC_TYPE_APP;
+
// TODO(akalin): Figure out if we need to allow some other types.
if (location() != Extension::INTERNAL) {
// We have a non-standard location.

Powered by Google App Engine
This is Rietveld 408576698