Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(87)

Issue 9340005: Merge 106846 - Before accessing a frame's script controller in V8 bindings, first check that the ... (Closed)

Created:
8 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106846 - Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists https://bugs.webkit.org/show_bug.cgi?id=77370 Reviewed by Adam Barth. I don't have a working reproduction of the crash yet. As soon as I have one, I will add new layout tests. * bindings/v8/PageScriptDebugServer.cpp: (WebCore::PageScriptDebugServer::addListener): * bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): * bindings/v8/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore): * page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): remove temporary debug code Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=106848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/WebCore/bindings/v8/PageScriptDebugServer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/WebCore/bindings/v8/ScheduledAction.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/v8/ScriptCachedFrameData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/DOMTimer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
8 years, 10 months ago (2012-02-06 22:06:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698