Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(624)

Issue 9340004: Merge 104501 - [chromium win] Creating lots of temporary canvas contexts will crash. (Closed)

Created:
8 years, 10 months ago by Stephen White
Modified:
8 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 104501 - [chromium win] Creating lots of temporary canvas contexts will crash. https://bugs.webkit.org/show_bug.cgi?id=68420 When using the skia port, the allocation of 2d canvas backing stores no longer needs to be done through a platform API (GDI/CG) because canvases now use skia for drawing text. Removing the allocation through GDI on windows prevents resource exhaustion due to unreferenced canvases that are awaiting garbage collection. Patch by Justin Novosad <junov@chromium.org>; on 2012-01-09 Reviewed by Stephen White. No new tests: Relying on existing canvas layout tests. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): * platform/graphics/ImageBuffer.h: * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::createNonPlatformCanvas): (WebCore::ImageBuffer::ImageBuffer): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=106845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M Source/WebCore/html/HTMLCanvasElement.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Stephen White
8 years, 10 months ago (2012-02-06 21:43:18 UTC) #1
Justin Novosad
8 years, 10 months ago (2012-02-06 21:56:17 UTC) #2
On 2012/02/06 21:43:18, Stephen White wrote:

lgtm

Powered by Google App Engine
This is Rietveld 408576698