runtime/vm/opt_code_generator_ia32.cc - Issue 9338002: Fixed a bug in isNegate intrinsified code, fixed negation for doubles (handling of negative zeros...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/opt_code_generator_ia32.cc

Issue 9338002: Fixed a bug in isNegate intrinsified code, fixed negation for doubles (handling of negative zeros... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/opt_code_generator_ia32.cc

===================================================================

--- runtime/vm/opt_code_generator_ia32.cc (revision 3970)

+++ runtime/vm/opt_code_generator_ia32.cc (working copy)

@@ -870,10 +870,9 @@

__ LoadObject(kResultRegister, double_object);

}

__ movsd(XMM0, FieldAddress(kOperandRegister, Double::value_offset()));

- __ xorps(XMM1, XMM1); // 0.0 -> XMM1.

ASSERT(node->kind() == Token::kSUB);

- __ subsd(XMM1, XMM0);

- __ movsd(FieldAddress(kResultRegister, Double::value_offset()), XMM1);

+ __ DoubleNegate(XMM0);

+ __ movsd(FieldAddress(kResultRegister, Double::value_offset()), XMM0);

if (CodeGenerator::IsResultNeeded(node)) {

if (node->info() != NULL) {

node->info()->set_is_temp(using_temp);

« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | tests/language/language.status » ('j') | no next file with comments »