Issue 1423. Enhanced welcome page.

Issue 1423. Enhanced welcome page.
http://code.google.com/p/dart/issues/detail?id=1423


R=pquitslund@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4039

[danrubel, 2012-02-07 06:00:46]

LGTM once comments have been addressed

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.core.prefs
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.core.prefs:1:
#Fri Feb 03 09:56:31 EST 2012
+1 Please do not check in prefs... or at least move them into a separate CL then
lets discuss the concept in the next standup meeting.
Thanks!

On 2012/02/06 23:49:25, pquitslund wrote:
> I'll defer to Dan, but I think in general, we aren't commit pref files...

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.ui.prefs
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.ui.prefs:1:
#Thu Feb 02 13:43:20 EST 2012
Same comment as prior prefs file

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/IntroEditor.java
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/IntroEditor.java:150:
+ " See <a href='http://www.dartlang.org'>dartlang.org</a> for more
information.");
Can all of this be moved into a welcome.html file which is read by this method?
That *.html file could contain a <!-- samples here --> tag that is replaced by
this method with dynamically generated html for each sample.

This could be addressed in a separate CL

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/SampleDescriptionHelper.java
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/SampleDescriptionHelper.java:130:
String devSamplesPath =
System.getProperty("dartEditor.development.samplesPath");
File installDir = new File(Platform.getInstallLocation().getURL().getFile());
File samples = new File(installDir, "samples");

[scheglov, 2012-02-08 16:07:22]

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.core.prefs
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.core.prefs:1:
#Fri Feb 03 09:56:31 EST 2012
On 2012/02/07 06:00:46, danrubel wrote:
> +1 Please do not check in prefs... or at least move them into a separate CL
then
> lets discuss the concept in the next standup meeting.
> Thanks!
> 
> On 2012/02/06 23:49:25, pquitslund wrote:
> > I'll defer to Dan, but I think in general, we aren't commit pref files...
> 

Done.

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.ui.prefs
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/.settings/org.eclipse.jdt.ui.prefs:1:
#Thu Feb 02 13:43:20 EST 2012
On 2012/02/07 06:00:46, danrubel wrote:
> Same comment as prior prefs file

Done.

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/IntroEditor.java
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/IntroEditor.java:150:
+ " See <a href='http://www.dartlang.org'>dartlang.org</a> for more
information.");
On 2012/02/07 06:00:46, danrubel wrote:
> Can all of this be moved into a welcome.html file which is read by this
method?
> That *.html file could contain a <!-- samples here --> tag that is replaced by
> this method with dynamically generated html for each sample.

Ah... Good idea!
Done.

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/SampleDescriptionHelper.java
(right):

https://chromiumcodereview.appspot.com/9335002/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/intro/SampleDescriptionHelper.java:130:
String devSamplesPath =
System.getProperty("dartEditor.development.samplesPath");
On 2012/02/07 06:00:46, danrubel wrote:
> File installDir = new File(Platform.getInstallLocation().getURL().getFile());
> File samples = new File(installDir, "samples");

OK for "user" branch.

But for development branch I still have to keep existing externally provided
"samples" location. I keep Eclipse outside of "git" repository, so
getInstallLocation() returns directory with "plugins", there are no....

OK, I've solved problem by using symbolic link from my Eclipse folder to actual
"samples" folder.