Fix some memory leaks.

Fix some memory leaks.

BUG=112803, 112795
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120827

[sky, 2012-02-06 17:55:47]

http://codereview.chromium.org/9333005/diff/1/ui/base/touch/touch_factory.cc
File ui/base/touch/touch_factory.cc (right):

http://codereview.chromium.org/9333005/diff/1/ui/base/touch/touch_factory.cc#...
ui/base/touch/touch_factory.cc:67: char* atom = XGetAtomName(display, v->label);
How about a scoping object?

http://codereview.chromium.org/9333005/diff/1/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

http://codereview.chromium.org/9333005/diff/1/ui/views/view_unittest.cc#newco...
ui/views/view_unittest.cc:2840: delete v1;
Can we delete this right after we remove it from the view hierarchy (and set it
to NULL)?

[sadrul, 2012-02-06 19:48:30]

http://codereview.chromium.org/9333005/diff/1/ui/base/touch/touch_factory.cc
File ui/base/touch/touch_factory.cc (right):

http://codereview.chromium.org/9333005/diff/1/ui/base/touch/touch_factory.cc#...
ui/base/touch/touch_factory.cc:67: char* atom = XGetAtomName(display, v->label);
On 2012/02/06 17:55:47, sky wrote:
> How about a scoping object?

Sounds good. Done.

http://codereview.chromium.org/9333005/diff/1/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

http://codereview.chromium.org/9333005/diff/1/ui/views/view_unittest.cc#newco...
ui/views/view_unittest.cc:2840: delete v1;
On 2012/02/06 17:55:47, sky wrote:
> Can we delete this right after we remove it from the view hierarchy (and set
it
> to NULL)?

Done.

[sky, 2012-02-06 21:43:00]

http://codereview.chromium.org/9333005/diff/3001/ui/base/touch/touch_factory.cc
File ui/base/touch/touch_factory.cc (right):

http://codereview.chromium.org/9333005/diff/3001/ui/base/touch/touch_factory....
ui/base/touch/touch_factory.cc:22: class XScopedString {
Should this live in ui/base/x?

[sadrul, 2012-02-07 19:45:24]

http://codereview.chromium.org/9333005/diff/3001/ui/base/touch/touch_factory.cc
File ui/base/touch/touch_factory.cc (right):

http://codereview.chromium.org/9333005/diff/3001/ui/base/touch/touch_factory....
ui/base/touch/touch_factory.cc:22: class XScopedString {
On 2012/02/06 21:43:00, sky wrote:
> Should this live in ui/base/x?

Sounds like a good idea. I moved this into x11_util (and used it in another
place XGetAtomName was being used)

[sky, 2012-02-07 20:55:01]

LGTM

http://codereview.chromium.org/9333005/diff/6001/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (right):

http://codereview.chromium.org/9333005/diff/6001/ui/base/x/x11_util.h#newcode262
ui/base/x/x11_util.h:262: explicit XScopedString(char *str) : string_(str) { }
'char *str' -> 'char* str' (same on line 268)

[sadrul, 2012-02-07 21:30:08]

http://codereview.chromium.org/9333005/diff/6001/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (right):

http://codereview.chromium.org/9333005/diff/6001/ui/base/x/x11_util.h#newcode262
ui/base/x/x11_util.h:262: explicit XScopedString(char *str) : string_(str) { }
On 2012/02/07 20:55:01, sky wrote:
> 'char *str' -> 'char* str' (same on line 268)

Whoops. Sorry! Fixed.