Use FILE thread for disk operations in TraceSubscriberStdio

content/browser/trace_message_filter.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/trace_message_filter.h"
 
 #include "content/browser/trace_controller.h"
 #include "content/common/child_process_messages.h"
 
 using content::BrowserMessageFilter;
@@ skipping 78 matching lines @@
     const std::vector<std::string>& known_categories) {
   // is_awaiting_end_ack_ should always be true here, but check in case the
   // child process is compromised.
   if (is_awaiting_end_ack_) {
     is_awaiting_end_ack_ = false;
     TraceController::GetInstance()->OnEndTracingAck(known_categories);
   }
 }
 
 void TraceMessageFilter::OnTraceDataCollected(const std::string& data) {
-  TraceController::GetInstance()->OnTraceDataCollected(
-      make_scoped_refptr(new base::debug::TraceLog::RefCountedString(data)));
+  scoped_refptr<base::RefCountedString> string(new base::RefCountedString());

[joth, 2012/02/08 13:22:20]

avoid calling is 'string' as that's already overloaded.

[Iain Merrick, 2012/02/08 14:11:24]

Done.

+  string->data() = data;

[Iain Merrick, 2012/02/08 12:07:05]

This is a copy, not sure if there's a way to avoid it. Can we take ownership of
strings from IPC messages?

[joth, 2012/02/08 13:22:20]

At least you're not adding a new copy ..
I think it could work if you make data a non-const ref. (opps!) because then you
could use RefCountedString::TakeString()

[Iain Merrick, 2012/02/08 14:11:24]

But I only have a const IPC::Message, so yeah, sadly not possible. Makes sense
as this is a MessageFilter, and the same Message will be passed to other
filters.

+  TraceController::GetInstance()->OnTraceDataCollected(string);
 }
 
 void TraceMessageFilter::OnTraceBufferFull() {
   TraceController::GetInstance()->OnTraceBufferFull();
 }
 
 void TraceMessageFilter::OnTraceBufferPercentFullReply(float percent_full) {
   if (is_awaiting_bpf_ack_) {
     is_awaiting_bpf_ack_ = false;
     TraceController::GetInstance()->OnTraceBufferPercentFullReply(
         percent_full);
   }
 }