Issue 9332017: Remove V1 authenticator support from Me2Me host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9332017: Remove V1 authenticator support from Me2Me host. (Closed)

Created:
8 years, 10 months ago by Sergey Ulanov

Modified:
8 years, 10 months ago

Reviewers:
Wez, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove V1 authenticator support from Me2Me host. BUG=110483 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120705

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -10 lines)			Patch
	M	remoting/protocol/me2me_host_authenticator_factory.cc	View		1 chunk	+3 lines, -10 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jamie

Should ticket 110483 be referenced? http://codereview.chromium.org/9332017/diff/1/remoting/protocol/me2me_host_authenticator_factory.cc File remoting/protocol/me2me_host_authenticator_factory.cc (right): http://codereview.chromium.org/9332017/diff/1/remoting/protocol/me2me_host_authenticator_factory.cc#newcode112 remoting/protocol/me2me_host_authenticator_factory.cc:112: shared_secret_hash_.hash_function); I take it ...

8 years, 10 months ago (2012-02-06 21:03:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/9332017/1

8 years, 10 months ago (2012-02-06 22:21:19 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-07 03:16:03 UTC) #5

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 120690, job name
was 9332017-1 (previous was lost) (previous was lost) (retry) (retry).

Expand Messages | Collapse Messages