Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 9332004: Fix leak in ComponentUpdaterTest.ProdVersionCheck. (Closed)

Created:
8 years, 10 months ago by Reid Kleckner
Modified:
8 years, 10 months ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Fix leak in ComponentUpdaterTest.ProdVersionCheck. R=cpu@chromium.org,timurrrr@chromium.org BUG=96295 TEST=Ran ComponentUpdaterTest.* under drmemory, RegisterComponent leak gone Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120778

Patch Set 1 #

Patch Set 2 : Remove unnecessary <vector> include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M chrome/browser/component_updater/component_updater_service_unittest.cc View 1 6 chunks +8 lines, -6 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Reid Kleckner
8 years, 10 months ago (2012-02-06 18:25:28 UTC) #1
Reid Kleckner
Adding Timur for OWNERS on tools/valgrind/.
8 years, 10 months ago (2012-02-06 18:26:52 UTC) #2
Timur Iskhodzhanov
You don't need any approval for the suppression changes, do you?
8 years, 10 months ago (2012-02-06 18:30:24 UTC) #3
Reid Kleckner (google)
I believe I do now that you've put "set noparent" in the OWNERS dir in ...
8 years, 10 months ago (2012-02-06 19:23:46 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
8 years, 10 months ago (2012-02-06 20:29:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/9332004/3001
8 years, 10 months ago (2012-02-06 20:39:58 UTC) #6
commit-bot: I haz the power
Try job failure for 9332004-3001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 22:59:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/9332004/3001
8 years, 10 months ago (2012-02-07 00:34:01 UTC) #8
commit-bot: I haz the power
Try job failure for 9332004-3001 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-02-07 03:28:32 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 03:29:52 UTC) #10
Try job failure for 9332004-3001 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698