Source/WebCore/editing/DeleteSelectionCommand.cpp - Issue 9331006: Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempti...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/editing/DeleteSelectionCommand.cpp

Issue 9331006: Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempti... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1025/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/editing/DeleteSelectionCommand.cpp

===================================================================

--- Source/WebCore/editing/DeleteSelectionCommand.cpp (revision 106819)

+++ Source/WebCore/editing/DeleteSelectionCommand.cpp (working copy)

@@ -418,6 +418,8 @@

if (startNode == m_startBlock && startOffset == 0 && canHaveChildrenForEditing(startNode) && !startNode->hasTagName(tableTag)) {

startOffset = 0;

startNode = startNode->traverseNextNode();

+ if (!startNode)

+ return;

}

if (startOffset >= caretMaxOffset(startNode) && startNode->isTextNode()) {

« no previous file with comments | « LayoutTests/editing/deleting/delete-start-block-expected.txt ('k') | no next file » | no next file with comments »