Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(875)

Issue 9331006: Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempti... (Closed)

Created:
8 years, 10 months ago by rniwa-cr
Modified:
8 years, 10 months ago
Reviewers:
rniwa-cr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block https://bugs.webkit.org/show_bug.cgi?id=77077 Reviewed by Enrica Casucci. The crash was caused by a missing null check after removing the position out of the start block. Fixed the bug by adding an early return. Tests: editing/deleting/delete-start-block.html editing/selection/move-into-empty-root-inline-box.html * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves https://bugs.webkit.org/show_bug.cgi?id=76812 Reviewed by Enrica Casucci. Add a regression test for the crash. Unfortunately, we can only test previousLinePosition. * editing/selection/move-into-empty-root-inline-box-expected.txt: Added. * editing/selection/move-into-empty-root-inline-box.html: Added. http://crbug.com/99408/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=106820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --2 lines) Patch
A + LayoutTests/editing/deleting/delete-start-block.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/deleting/delete-start-block-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/editing/DeleteSelectionCommand.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
8 years, 10 months ago (2012-02-06 19:01:05 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698