Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9328041: [filebrowser] In Gallery, do not allow file names starting with dot. (Closed)

Created:
8 years, 10 months ago by dgozman
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

[filebrowser] In Gallery, do not allow file names starting with dot. BUG=chromium-os:23777 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120774

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/extensions/extension_file_browser_private_api.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/gallery.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgozman
May you have a look, please?
8 years, 10 months ago (2012-02-06 13:06:05 UTC) #1
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/9328041/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/9328041/diff/1/chrome/app/generated_resources.grd#newcode9989 chrome/app/generated_resources.grd:9989: <message name="IDS_FILE_BROWSER_GALLERY_FILE_STARTS_WITH_DOT" desc="In the Gallery, the message informing that ...
8 years, 10 months ago (2012-02-06 13:16:27 UTC) #2
dgozman
https://chromiumcodereview.appspot.com/9328041/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/9328041/diff/1/chrome/app/generated_resources.grd#newcode9989 chrome/app/generated_resources.grd:9989: <message name="IDS_FILE_BROWSER_GALLERY_FILE_STARTS_WITH_DOT" desc="In the Gallery, the message informing that ...
8 years, 10 months ago (2012-02-06 13:22:54 UTC) #3
dgozman
PTAL
8 years, 10 months ago (2012-02-07 12:02:03 UTC) #4
Vladislav Kaznacheev
lgtm
8 years, 10 months ago (2012-02-07 13:54:08 UTC) #5
Vladislav Kaznacheev
lgtm lgtm
8 years, 10 months ago (2012-02-07 13:54:08 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 14:01:45 UTC) #7 
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698