Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3203)

Unified Diff: build/common.gypi

Issue 9328004: Revert 120385 - linux: use an in-tree copy of gold by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | tools/licenses.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 120396)
+++ build/common.gypi (working copy)
@@ -376,15 +376,6 @@
}, {
'enable_plugin_installation%': 1,
}],
-
- # Set to 0 to not use third_party/gold as the linker.
- # On by default for x64 Linux. Off for ChromeOS as cross-compiling
- # makes things complicated.
- ['chromeos==0 and host_arch=="x64"', {
- 'linux_use_gold_binary%': 1,
- }, {
- 'linux_use_gold_binary%': 0,
- }],
],
},
@@ -443,7 +434,6 @@
'enable_web_intents%': '<(enable_web_intents)',
'enable_web_intents_tag%': '<(enable_web_intents_tag)',
'enable_plugin_installation%': '<(enable_plugin_installation)',
- 'linux_use_gold_binary%': '<(linux_use_gold_binary)',
'use_canvas_skia_skia%': '<(use_canvas_skia_skia)',
# Whether to build for Wayland display server
'use_wayland%': 0,
@@ -1991,19 +1981,6 @@
'defines': ['KEEP_SHADOW_STACKS'],
'cflags': ['-finstrument-functions'],
}],
- ['linux_use_gold_binary==1', {
- 'variables': {
- # We pass the path to gold to the compiler. gyp leaves
- # unspecified what the cwd is when running the compiler,
- # so the normal gyp path-munging fails us. This hack
- # gets the right path.
- 'gold_path': '<(PRODUCT_DIR)/../../third_party/gold',
- },
- 'ldflags': [
- # Put our gold binary in the search path for the linker.
- '-B<(gold_path)',
- ],
- }],
],
},
}],
« no previous file with comments | « DEPS ('k') | tools/licenses.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698