Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 9325075: Tokenize Http headers on both /r and /n. (Closed)

Created:
8 years, 10 months ago by bbudge
Modified:
8 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Tokenize Http headers on both /r and /n. The new WebKit Http request header validation code fails if values contain /r. BUG=112901 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
bbudge
8 years, 10 months ago (2012-02-06 19:00:04 UTC) #1
brettw
lgtm
8 years, 10 months ago (2012-02-06 19:26:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9325075/1
8 years, 10 months ago (2012-02-06 21:23:27 UTC) #3
commit-bot: I haz the power
Try job failure for 9325075-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 10 months ago (2012-02-06 23:42:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9325075/1
8 years, 10 months ago (2012-02-06 23:46:26 UTC) #5
commit-bot: I haz the power
Try job failure for 9325075-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
8 years, 10 months ago (2012-02-07 01:18:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9325075/1
8 years, 10 months ago (2012-02-07 01:22:56 UTC) #7
commit-bot: I haz the power
Try job failure for 9325075-1 (previous was lost) (previous was lost) (retry) on mac_rel for ...
8 years, 10 months ago (2012-02-07 06:07:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9325075/1
8 years, 10 months ago (2012-02-07 18:53:07 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 21:06:03 UTC) #10
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 120793, job name
was 9325075-1 (retry) (previous was lost) (previous was lost) (previous was
lost).

Powered by Google App Engine
This is Rietveld 408576698