Enable internal gold for ChromeOS.

Enable internal gold for ChromeOS.


BUG=None
TEST=Manual: chrome builds with chromeos=1 on a 64-bit machine without a system gold binary.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120762

[Evan Martin, 2012-02-06 17:19:21]

Will this break the ARM cross compile?

[Ivan Korotkov, 2012-02-06 22:09:02]

cros_arm bot builds fine (looks like the only bot with ARM arch).

[Evan Martin, 2012-02-06 22:12:34]

On 2012/02/06 22:09:02, Ivan Korotkov wrote:
> cros_arm bot builds fine (looks like the only bot with ARM arch).

LGTM then, but please only submit it if you're around to catch any build
failures.  I don't think gold supports ARM out of the box so I would expect this
to fail.

[rcui1, 2012-02-07 00:36:36]

On 2012/02/06 22:09:02, Ivan Korotkov wrote:
> cros_arm bot builds fine (looks like the only bot with ARM arch).

Can you also run it through the cros_x86, cros_arm, and cros_tegra2 trybots?

[Ivan Korotkov, 2012-02-07 11:03:17]

All trybots mentioned pass, submitting.

[Evan Martin, 2012-02-09 18:56:59]

On 2012/02/07 11:03:17, Ivan Korotkov wrote:
> All trybots mentioned pass, submitting.

It appears that some of the ChromeOS bots weren't successfully using this,
causing my follow-up patch to get reverted.

http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...

Search for [--threads] on that page to see the error message.
It appears the flag is being passed to the bot, but it's not actually using
gold.

[Evan Martin, 2012-02-09 19:27:38]

On Thu, Feb 9, 2012 at 10:56 AM,  <evan@chromium.org> wrote:
> On 2012/02/07 11:03:17, Ivan Korotkov wrote:
>>
>> All trybots mentioned pass, submitting.
>
>
> It appears that some of the ChromeOS bots weren't successfully using this,
> causing my follow-up patch to get reverted.
>
>
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...
>
> Search for [--threads] on that page to see the error message.
> It appears the flag is being passed to the bot, but it's not actually using
> gold.

Additionally,
http://chrome-master2.mtv:8011/builders/cros%20trunk/builds/5820/steps/compil...

"make" seems to fail for reasons I can't identify.
This is the reason I didn't turn this on for ChromeOS initially: there
are all these random bots that aren't covered by the trybots.  :(

  LINK(target) out/Release/performance_ui_tests
out/Release/../../third_party/gold/gold64: warning: skipping
incompatible /lib/libdbus-1.so while searching for dbus-1
out/Release/../../third_party/gold/gold64: warning: skipping
incompatible /lib/libdbus-1.so while searching for dbus-1
  LINK(target) out/Release/performance_ui_tests: Finished
program finished with exit code 2
elapsedTime=953.039296

[Evan Martin, 2012-02-09 19:34:30]

On Thu, Feb 9, 2012 at 11:27 AM, Evan Martin <evan@chromium.org> wrote:
> Additionally,
>
http://chrome-master2.mtv:8011/builders/cros%20trunk/builds/5820/steps/compil...
>
> "make" seems to fail for reasons I can't identify.
> This is the reason I didn't turn this on for ChromeOS initially: there
> are all these random bots that aren't covered by the trybots.  :(
>
>  LINK(target) out/Release/performance_ui_tests
> out/Release/../../third_party/gold/gold64: warning: skipping
> incompatible /lib/libdbus-1.so while searching for dbus-1
> out/Release/../../third_party/gold/gold64: warning: skipping
> incompatible /lib/libdbus-1.so while searching for dbus-1
>  LINK(target) out/Release/performance_ui_tests: Finished
> program finished with exit code 2
> elapsedTime=953.039296

I'm told this is unrelated to my change.  (But the other failure is real.)

[Ivan Korotkov, 2012-02-10 15:09:30]

Sorry, I've missed what's happending -- was using internal gold for CrOS
wrong?.. It doesn't look like this commit was reverted.

[Evan Martin, 2012-02-10 19:11:46]

On 2012/02/10 15:09:30, Ivan Korotkov wrote:
> Sorry, I've missed what's happending -- was using internal gold for CrOS
> wrong?.. It doesn't look like this commit was reverted.

See "use_gold_flags" here:
http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=build/common.gypi;h=7...

The failing buildbot appeared to not run gold.  I think the problem is maybe
that it's a 32-bit bot, which means it gets the fallback ld (see the shell
script third_party/gold/ld).