Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: src/property.h

Issue 9325060: Removed PropertyDetails::IsProperty. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/property-details.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 bool IsReadOnly() { return details_.IsReadOnly(); } 257 bool IsReadOnly() { return details_.IsReadOnly(); }
258 bool IsDontDelete() { return details_.IsDontDelete(); } 258 bool IsDontDelete() { return details_.IsDontDelete(); }
259 bool IsDontEnum() { return details_.IsDontEnum(); } 259 bool IsDontEnum() { return details_.IsDontEnum(); }
260 bool IsDeleted() { return details_.IsDeleted(); } 260 bool IsDeleted() { return details_.IsDeleted(); }
261 bool IsFound() { return lookup_type_ != NOT_FOUND; } 261 bool IsFound() { return lookup_type_ != NOT_FOUND; }
262 bool IsHandler() { return lookup_type_ == HANDLER_TYPE; } 262 bool IsHandler() { return lookup_type_ == HANDLER_TYPE; }
263 263
264 // Is the result is a property excluding transitions and the null 264 // Is the result is a property excluding transitions and the null
265 // descriptor? 265 // descriptor?
266 bool IsProperty() { 266 bool IsProperty() {
267 return IsFound() && GetPropertyDetails().IsProperty(); 267 return IsFound() && IsRealProperty(GetPropertyDetails().type());
268 } 268 }
269 269
270 bool IsCacheable() { return cacheable_; } 270 bool IsCacheable() { return cacheable_; }
271 void DisallowCaching() { cacheable_ = false; } 271 void DisallowCaching() { cacheable_ = false; }
272 272
273 Object* GetLazyValue() { 273 Object* GetLazyValue() {
274 switch (type()) { 274 switch (type()) {
275 case FIELD: 275 case FIELD:
276 return holder()->FastPropertyAt(GetFieldIndex()); 276 return holder()->FastPropertyAt(GetFieldIndex());
277 case NORMAL: { 277 case NORMAL: {
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 JSReceiver* holder_; 375 JSReceiver* holder_;
376 int number_; 376 int number_;
377 bool cacheable_; 377 bool cacheable_;
378 PropertyDetails details_; 378 PropertyDetails details_;
379 }; 379 };
380 380
381 381
382 } } // namespace v8::internal 382 } } // namespace v8::internal
383 383
384 #endif // V8_PROPERTY_H_ 384 #endif // V8_PROPERTY_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/property-details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698