Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 9325059: [Clean up] Fix style guide nits in chrome/browser/resources/ntp4. (Closed)

Created:
8 years, 10 months ago by Dan Beam
Modified:
8 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[Clean up] Fix style guide nits in chrome/browser/resources/ntp4. R=estade@chromium.org TEST=No regressions, CSS follows style guide / passes presubmit. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120713

Patch Set 1 #

Total comments: 3

Patch Set 2 : fixing margin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -69 lines) Patch
M chrome/browser/resources/ntp4/apps_page.css View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/ntp4/most_visited_page.css View 8 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/resources/ntp4/nav_dot.css View 4 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/recently_closed.css View 1 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.css View 5 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dan Beam
8 years, 10 months ago (2012-02-06 10:31:43 UTC) #1
Dan Beam
Oh, sorry, I should mention this is just re-arranging and copyright stuff. Please just review ...
8 years, 10 months ago (2012-02-06 10:44:50 UTC) #2
Evan Stade
lgtm
8 years, 10 months ago (2012-02-06 21:18:48 UTC) #3
Dan Beam
https://chromiumcodereview.appspot.com/9325059/diff/1/chrome/browser/resources/ntp4/recently_closed.css File chrome/browser/resources/ntp4/recently_closed.css (right): https://chromiumcodereview.appspot.com/9325059/diff/1/chrome/browser/resources/ntp4/recently_closed.css#newcode79 chrome/browser/resources/ntp4/recently_closed.css:79: margin: 8px; Will this need to be overridden or ...
8 years, 10 months ago (2012-02-07 00:43:04 UTC) #4
Evan Stade
https://chromiumcodereview.appspot.com/9325059/diff/1/chrome/browser/resources/ntp4/recently_closed.css File chrome/browser/resources/ntp4/recently_closed.css (right): https://chromiumcodereview.appspot.com/9325059/diff/1/chrome/browser/resources/ntp4/recently_closed.css#newcode79 chrome/browser/resources/ntp4/recently_closed.css:79: margin: 8px; On 2012/02/07 00:43:05, Dan Beam wrote: > ...
8 years, 10 months ago (2012-02-07 00:55:54 UTC) #5
Dan Beam
https://chromiumcodereview.appspot.com/9325059/diff/1/chrome/browser/resources/ntp4/recently_closed.css File chrome/browser/resources/ntp4/recently_closed.css (right): https://chromiumcodereview.appspot.com/9325059/diff/1/chrome/browser/resources/ntp4/recently_closed.css#newcode79 chrome/browser/resources/ntp4/recently_closed.css:79: margin: 8px; On 2012/02/07 00:55:54, Evan Stade wrote: > ...
8 years, 10 months ago (2012-02-07 01:07:03 UTC) #6
Evan Stade
lgtm -- Evan Stade On Mon, Feb 6, 2012 at 5:07 PM, <dbeam@chromium.org> wrote: > ...
8 years, 10 months ago (2012-02-07 01:08:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9325059/7001
8 years, 10 months ago (2012-02-07 01:14:18 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 04:33:31 UTC) #9
Change committed as 120713

Powered by Google App Engine
This is Rietveld 408576698