Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: runtime/vm/code_patcher_ia32_test.cc

Issue 9325047: Add token index position to classes and types for more accurate error reporting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator_x64_test.cc ('k') | runtime/vm/code_patcher_x64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_ia32_test.cc
===================================================================
--- runtime/vm/code_patcher_ia32_test.cc (revision 3964)
+++ runtime/vm/code_patcher_ia32_test.cc (working copy)
@@ -18,8 +18,6 @@
namespace dart {
-static const intptr_t kPos = 1; // Dummy token index in non-existing source.
-
CODEGEN_TEST_GENERATE(NativePatchStaticCall, test) {
SequenceNode* node_seq = test->node_sequence();
const int num_params = 0;
@@ -28,8 +26,8 @@
String::ZoneHandle(String::NewSymbol("TestStaticCallPatching"));
NativeFunction native_function = reinterpret_cast<NativeFunction>(
NATIVE_ENTRY_FUNCTION(TestStaticCallPatching));
- node_seq->Add(new ReturnNode(kPos,
- new NativeBodyNode(kPos,
+ node_seq->Add(new ReturnNode(Scanner::kDummyTokenIndex,
+ new NativeBodyNode(Scanner::kDummyTokenIndex,
native_name,
native_function,
num_params,
@@ -38,9 +36,10 @@
CODEGEN_TEST2_GENERATE(PatchStaticCall, function, test) {
SequenceNode* node_seq = test->node_sequence();
- ArgumentListNode* arguments = new ArgumentListNode(kPos);
- node_seq->Add(new ReturnNode(kPos,
- new StaticCallNode(kPos, function, arguments)));
+ ArgumentListNode* arguments = new ArgumentListNode(Scanner::kDummyTokenIndex);
+ node_seq->Add(new ReturnNode(Scanner::kDummyTokenIndex,
+ new StaticCallNode(Scanner::kDummyTokenIndex,
+ function, arguments)));
}
CODEGEN_TEST2_RUN(PatchStaticCall, NativePatchStaticCall, Instance::null());
« no previous file with comments | « runtime/vm/code_generator_x64_test.cc ('k') | runtime/vm/code_patcher_x64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698