Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 9325047: Add token index position to classes and types for more accurate error reporting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/class_finalizer_test.cc ('k') | runtime/vm/code_generator_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 3964)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -2299,14 +2299,9 @@
// The type arguments are compile time constants.
AbstractTypeArguments& type_arguments = AbstractTypeArguments::ZoneHandle();
// TODO(regis): Temporary type should be allocated in new gen heap.
- Type& type = Type::Handle(Type::New(instantiator_class, type_arguments));
- Error& error = Error::Handle();
- type ^= ClassFinalizer::FinalizeAndCanonicalizeType(instantiator_class,
- type,
- &error);
- if (!error.IsNull()) {
- ErrorMsg(token_index, error.ToErrorCString());
- }
+ Type& type = Type::Handle(
+ Type::New(instantiator_class, type_arguments, token_index));
+ type ^= ClassFinalizer::FinalizeType(instantiator_class, type);
type_arguments = type.arguments();
__ PushObject(type_arguments);
} else {
« no previous file with comments | « runtime/vm/class_finalizer_test.cc ('k') | runtime/vm/code_generator_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698