Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: runtime/vm/class_finalizer.h

Issue 9325047: Add token index position to classes and types for more accurate error reporting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast_test.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.h
===================================================================
--- runtime/vm/class_finalizer.h (revision 3964)
+++ runtime/vm/class_finalizer.h (working copy)
@@ -41,11 +41,10 @@
AbstractType* interface,
AbstractType* conflicting);
- // Finalize and canonicalize type while parsing class cls.
- // Set the error message on failure (to Error::null() if no error).
- static RawAbstractType* FinalizeAndCanonicalizeType(const Class& cls,
- const AbstractType& type,
- Error* error);
+ // Finalize given type while parsing class cls.
+ // Also canonicalize type if applicable.
+ static RawAbstractType* FinalizeType(const Class& cls,
+ const AbstractType& type);
// Pending classes are classes that need to be finalized.
static void AddPendingClasses(const GrowableArray<const Class*>& classes);
@@ -82,8 +81,6 @@
static void FinalizeTypeArguments(const Class& cls,
const AbstractTypeArguments& arguments);
static void ResolveType(const Class& cls, const AbstractType& type);
- static RawAbstractType* FinalizeType(const Class& cls,
- const AbstractType& type);
static void ResolveAndFinalizeUpperBounds(const Class& cls);
static void VerifyUpperBounds(const Class& cls,
const AbstractTypeArguments& arguments);
« no previous file with comments | « runtime/vm/ast_test.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698