Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: runtime/vm/ast_test.cc

Issue 9325047: Add token index position to classes and types for more accurate error reporting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast_printer_test.cc ('k') | runtime/vm/class_finalizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/ast_test.cc
===================================================================
--- runtime/vm/ast_test.cc (revision 3964)
+++ runtime/vm/ast_test.cc (working copy)
@@ -12,15 +12,11 @@
namespace dart {
-static const intptr_t kPos = 1; // Dummy token index in non-existing source.
-
-
TEST_CASE(Ast) {
- const intptr_t kPos = 1; // Dummy token index in non-existing source.
- LocalVariable* v = new LocalVariable(kPos,
+ LocalVariable* v = new LocalVariable(Scanner::kDummyTokenIndex,
String::ZoneHandle(String::New("v")),
Type::ZoneHandle(Type::DynamicType()));
- AstNode* ll = new LoadLocalNode(kPos, *v);
+ AstNode* ll = new LoadLocalNode(Scanner::kDummyTokenIndex, *v);
EXPECT(ll->IsLoadLocalNode());
EXPECT(!ll->IsLiteralNode());
LoadLocalNode* lln = ll->AsLoadLocalNode();
@@ -28,7 +24,7 @@
v->set_index(1);
EXPECT_EQ(1, v->index());
- LocalVariable* p = new LocalVariable(kPos,
+ LocalVariable* p = new LocalVariable(Scanner::kDummyTokenIndex,
String::ZoneHandle(String::New("p")),
Type::ZoneHandle(Type::DynamicType()));
EXPECT(!p->HasIndex());
@@ -36,19 +32,21 @@
EXPECT(p->HasIndex());
EXPECT_EQ(-1, p->index());
- ReturnNode* r = new ReturnNode(kPos, lln);
+ ReturnNode* r = new ReturnNode(Scanner::kDummyTokenIndex, lln);
EXPECT_EQ(lln, r->value());
- LiteralNode* l = new LiteralNode(kPos, Smi::ZoneHandle(Smi::New(3)));
+ LiteralNode* l =
+ new LiteralNode(Scanner::kDummyTokenIndex, Smi::ZoneHandle(Smi::New(3)));
EXPECT(l->literal().IsSmi());
EXPECT_EQ(Smi::New(3), l->literal().raw());
- BinaryOpNode* b = new BinaryOpNode(kPos, Token::kADD, l, lln);
+ BinaryOpNode* b =
+ new BinaryOpNode(Scanner::kDummyTokenIndex, Token::kADD, l, lln);
EXPECT_EQ(Token::kADD, b->kind());
EXPECT_EQ(l, b->left());
EXPECT_EQ(lln, b->right());
- UnaryOpNode* u = new UnaryOpNode(kPos, Token::kSUB, b);
+ UnaryOpNode* u = new UnaryOpNode(Scanner::kDummyTokenIndex, Token::kSUB, b);
EXPECT_EQ(Token::kSUB, u->kind());
EXPECT_EQ(b, u->operand());
« no previous file with comments | « runtime/vm/ast_printer_test.cc ('k') | runtime/vm/class_finalizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698