Issue 9325045: [extensions] tool tip for trash icon

Issue 9325045: [extensions] tool tip for trash icon (Closed)

Created:
8 years, 10 months ago by Evan Stade

Modified:
8 years, 10 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[extensions] tool tip for trash icon BUG=112496 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120677

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/resources/extensions/extension_list.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/options/extension_settings_handler.cc	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm w/meme http://codereview.chromium.org/9325045/diff/1/chrome/browser/ui/webui/options/extension_settings_handler.cc File chrome/browser/ui/webui/options/extension_settings_handler.cc (right): http://codereview.chromium.org/9325045/diff/1/chrome/browser/ui/webui/options/extension_settings_handler.cc#newcode575 chrome/browser/ui/webui/options/extension_settings_handler.cc:575: // uber extensions. TODO? Why not DO?

8 years, 10 months ago (2012-02-04 02:19:06 UTC) #2

Evan Stade

http://codereview.chromium.org/9325045/diff/1/chrome/browser/ui/webui/options/extension_settings_handler.cc File chrome/browser/ui/webui/options/extension_settings_handler.cc (right): http://codereview.chromium.org/9325045/diff/1/chrome/browser/ui/webui/options/extension_settings_handler.cc#newcode575 chrome/browser/ui/webui/options/extension_settings_handler.cc:575: // uber extensions. On 2012/02/04 02:19:06, Dan Beam wrote: ...

8 years, 10 months ago (2012-02-04 02:37:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9325045/1

8 years, 10 months ago (2012-02-04 03:39:19 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-04 05:15:26 UTC) #5

Try job failure for 9325045-1 (retry) on mac_rel for step "net_unittests".
It's a second try, previously, step "net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages