Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: media/filters/audio_renderer_base.cc

Issue 9325044: Remove AudioDecoder from the Filter heirarchy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved audio_decoder_ out of Pipeline; AudioRendererBase is in charge of it now. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_base.cc
diff --git a/media/filters/audio_renderer_base.cc b/media/filters/audio_renderer_base.cc
index 445b2d1dd54cde6154f9f58ccbd39d3a43c7b47c..4ba5c483466297931cd18d972bd8ae0de0cd17d5 100644
--- a/media/filters/audio_renderer_base.cc
+++ b/media/filters/audio_renderer_base.cc
@@ -10,6 +10,7 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/logging.h"
+#include "media/base/audio_decoder.h"
scherkus (not reviewing) 2012/02/06 21:04:04 this is included in .h
Ami GONE FROM CHROMIUM 2012/02/06 21:38:48 Done.
#include "media/base/filter_host.h"
namespace media {
@@ -51,6 +52,10 @@ void AudioRendererBase::Pause(const base::Closure& callback) {
}
}
+void AudioRendererBase::Flush(const base::Closure& callback) {
+ decoder_->Reset(callback);
+}
+
void AudioRendererBase::Stop(const base::Closure& callback) {
OnStop();
{
@@ -84,7 +89,7 @@ void AudioRendererBase::Seek(base::TimeDelta time, const FilterStatusCB& cb) {
algorithm_->FlushBuffers();
}
-void AudioRendererBase::Initialize(AudioDecoder* decoder,
+void AudioRendererBase::Initialize(const scoped_refptr<AudioDecoder> decoder,
scherkus (not reviewing) 2012/02/06 21:04:04 const-ref
Ami GONE FROM CHROMIUM 2012/02/06 21:38:48 Done.
const PipelineStatusCB& init_callback,
const base::Closure& underflow_callback,
const AudioTimeCB& audio_time_cb) {

Powered by Google App Engine
This is Rietveld 408576698