Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: media/base/pipeline.h

Issue 9325044: Remove AudioDecoder from the Filter heirarchy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR responses. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index 771ccdf45f3bef62cebc5a3be7fe708970c28de6..c960912075f94b4254ed941f229e623fbbd5afca 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -35,21 +35,6 @@ class MediaLog;
class VideoDecoder;
class VideoRenderer;
-// TODO(scherkus): this should be moved alongside host interface defintions.
-struct PipelineStatistics {
- PipelineStatistics()
- : audio_bytes_decoded(0),
- video_bytes_decoded(0),
- video_frames_decoded(0),
- video_frames_dropped(0) {
- }
-
- uint32 audio_bytes_decoded; // Should be uint64?
- uint32 video_bytes_decoded; // Should be uint64?
- uint32 video_frames_decoded;
- uint32 video_frames_dropped;
-};
-
enum NetworkEvent {
DOWNLOAD_CONTINUED,
DOWNLOAD_PAUSED,
@@ -571,6 +556,9 @@ class MEDIA_EXPORT Pipeline
PipelineStatus status_;
// Whether the media contains rendered audio and video streams.
+ // TODO(fischman,scherkus): replace these with checks for
+ // {audio,video}_decoder_ once extraction of {Audio,Video}Decoder from the
+ // Filter heirarchy is done.
bool has_audio_;
bool has_video_;
@@ -628,7 +616,7 @@ class MEDIA_EXPORT Pipeline
// Helper class that stores filter references during pipeline
// initialization.
- class PipelineInitState;
+ struct PipelineInitState;
scoped_ptr<PipelineInitState> pipeline_init_state_;
// Statistics.
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698