Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: media/base/filter_collection.h

Issue 9325044: Remove AudioDecoder from the Filter heirarchy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR responses. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_decoder.cc ('k') | media/base/filter_collection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filter_collection.h
diff --git a/media/base/filter_collection.h b/media/base/filter_collection.h
index 35bd1deb86c0871f675e7c69bc73ad3b2eced17c..12a3a2fc9f6b79dd04d9e68d7f43e7efbb2fd4e7 100644
--- a/media/base/filter_collection.h
+++ b/media/base/filter_collection.h
@@ -13,6 +13,8 @@
namespace media {
+class AudioDecoder;
+
// This is a collection of Filter objects used to form a media playback
// pipeline. See src/media/base/pipeline.h for more information.
class MEDIA_EXPORT FilterCollection {
@@ -26,7 +28,7 @@ class MEDIA_EXPORT FilterCollection {
// Adds a filter to the collection.
void AddVideoDecoder(VideoDecoder* filter);
- void AddAudioDecoder(AudioDecoder* filter);
+ void AddAudioDecoder(AudioDecoder* audio_decoder);
void AddVideoRenderer(VideoRenderer* filter);
void AddAudioRenderer(AudioRenderer* filter);
@@ -41,7 +43,7 @@ class MEDIA_EXPORT FilterCollection {
// If a filter is returned it is removed from the collection.
// Filters are selected in FIFO order.
void SelectVideoDecoder(scoped_refptr<VideoDecoder>* filter_out);
- void SelectAudioDecoder(scoped_refptr<AudioDecoder>* filter_out);
+ void SelectAudioDecoder(scoped_refptr<AudioDecoder>* out);
void SelectVideoRenderer(scoped_refptr<VideoRenderer>* filter_out);
void SelectAudioRenderer(scoped_refptr<AudioRenderer>* filter_out);
@@ -50,7 +52,6 @@ class MEDIA_EXPORT FilterCollection {
// the following types. This is used to mark, identify, and support
// downcasting of different filter types stored in the filters_ list.
enum FilterType {
- AUDIO_DECODER,
VIDEO_DECODER,
AUDIO_RENDERER,
VIDEO_RENDERER,
@@ -61,6 +62,7 @@ class MEDIA_EXPORT FilterCollection {
typedef std::list<FilterListElement> FilterList;
FilterList filters_;
scoped_ptr<DemuxerFactory> demuxer_factory_;
+ std::list<scoped_refptr<AudioDecoder> > audio_decoders_;
// Helper function that adds a filter to the filter list.
void AddFilter(FilterType filter_type, Filter* filter);
« no previous file with comments | « media/base/audio_decoder.cc ('k') | media/base/filter_collection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698