dart/frog/method_data.dart - Issue 9325029: Fix for issue 1480: analyze a method even if it does not have a body, and do not try to evaluate ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/method_data.dart

Issue 9325029: Fix for issue 1480: analyze a method even if it does not have a body, and do not try to evaluate ... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/frog/gen.dart ('K') | « dart/frog/gen.dart ('k') | dart/tests/language/src/BodyLessConstructorWrongArgNegativeTest.dart » ('j') | dart/tests/language/src/BodyLessConstructorWrongArgNegativeTest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/frog/method_data.dart

===================================================================

--- dart/frog/method_data.dart (revision 3892)

+++ dart/frog/method_data.dart (working copy)

@@ -47,8 +47,6 @@

}

void analyze() {

- // TODO(jimhug): Is there really no analysis to do for a missing body?

- if (body === null) return;

var ma = new MethodAnalyzer(baseMethod, body);

ma.analyze(context);

// TODO(jimhug): Add support for specializing on type parameters.