Fix for issue 1480: analyze a method even if it does not have a body, and do not try to evaluate ...

dart/frog/analyze.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A simple code analyzer for Dart.
  *
  * Currently used to ensure all concrete generic types are visited.
  * Also performs all static type checks - so these don't need to be
  * done in later phases.
@@ skipping 28 matching lines @@
       thisValue = new PureStaticValue(method.declaringType, null);
     }
     var values = [];
     for (var p in method.parameters) {
       values.add(new PureStaticValue(p.type, null));
     }
     var args = new Arguments(null, values);
 
     _frame = new CallFrame(this, method, thisValue, args, context);
     _bindArguments(_frame.args);
-    body.visit(this);
+
+    // Visit the super or this call in a constructor, if any.
+    final declaredInitializers = method.definition.dynamic.initializers;
+    if (declaredInitializers != null) {
+      for (var init in declaredInitializers) {
+        if (init is CallExpression) {
+          visitCallExpression(init, true);
+        }
+      }
+    }
+
+    if (body != null) body.visit(this);
   }
 
   /* Checks whether or not a particular TypeReference Node includes references
    * to type parameters. */
   bool _hasTypeParams(node) {
     if (node is NameTypeReference) {
       var name = node.name.name;
       return (method.declaringType.lookupTypeParam(name) != null);
     } else if (node is GenericTypeReference) {
       for (var typeArg in node.typeArguments) {
@@ skipping 327 matching lines @@
   visitLambdaExpression(LambdaExpression node) {
     var name = (node.func.name != null) ? node.func.name.name : '';
 
     MethodMember meth = _makeLambdaMethod(name, node.func);
     // TODO(jimhug): Worry about proper scope for recursive lambda.
     meth.methodData.analyze();
 
     return _frame._makeValue(world.functionType, node);
   }
 
-  Value visitCallExpression(CallExpression node) {
+  analyzeInitializerConstructorCall(CallExpression node,
+                                    Expression receiver,
+                                    String name) {
+    var type = _frame.method.declaringType;
+    if (receiver is SuperExpression) {
+      type = type.parent;
+    }
+    var member = type.getConstructor(name == null ? '' : name);
+    if (member !== null) {
+      return member.invoke(_frame, node, _frame.makeThisValue(node),
+                           _visitArgs(node.arguments));
+    } else {
+      String constructorName = name == null ? '' : '.$name';
+      world.warning('cannot find constructor "${type.name}$constructorName"',
+                    node.span);
+      return _frame._makeValue(world.varType, node);
+    }
+  }
+
+  bool isThisOrSuper(Expression node) {
+    return node is ThisExpression || node is SuperExpression;
+  }
+
+  Value visitCallExpression(CallExpression node,
+                            [bool visitingInitializers = false]) {
     var target;
     var position = node.target;
     var name = ':call';
     if (node.target is DotExpression) {
       DotExpression dot = node.target;
       target = dot.self.visit(this);
       name = dot.name.name;
-      position = dot.name;
+      if (isThisOrSuper(dot.self) && visitingInitializers) {
+        return analyzeInitializerConstructorCall(node, dot.self, name);
+      } else {
+        position = dot.name;
+      }
+    } else if (isThisOrSuper(node.target) && visitingInitializers) {
+      return analyzeInitializerConstructorCall(node, node.target, null);
     } else if (node.target is VarExpression) {
       VarExpression varExpr = node.target;
       name = varExpr.name.name;
       // First check in block scopes.
       target = _frame.lookup(name);
       if (target != null) {
         return target.get(position).invoke(_frame, ':call', node,
           _visitArgs(node.arguments));
       }
 
@@ skipping 325 matching lines @@
     for (var item in node.pieces) {
       var val = visitValue(item);
       var sval = val.invoke(_frame, 'toString', item, Arguments.EMPTY);
       ret = ret.binop(TokenKind.ADD, sval, _frame, item);
     }
     return _frame._makeValue(world.stringType, node); //???ret;
     */
   }
 }