Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: frog/leg/emitter.dart

Issue 9325023: Support noSuchMethod for methods that take named parameters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language-leg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/emitter.dart
===================================================================
--- frog/leg/emitter.dart (revision 3891)
+++ frog/leg/emitter.dart (working copy)
@@ -301,10 +301,10 @@
String noSuchMethodName =
namer.instanceMethodName(Compiler.NO_SUCH_METHOD, 2);
- void generateMethod(String methodName, String jsName, int arity) {
+ void generateMethod(String methodName, String jsName, Selector selector) {
buffer.add('$prototype.$jsName = function');
StringBuffer args = new StringBuffer();
- for (int i = 0; i < arity; i++) {
+ for (int i = 0; i < selector.argumentCount; i++) {
if (i != 0) args.add(', ');
args.add('arg$i');
}
@@ -318,21 +318,21 @@
if (objectClass.lookupLocalMember(methodName) === null
&& methodName != Namer.OPERATOR_EQUALS) {
for (Selector selector in selectors) {
- int arity = selector.argumentCount;
- String jsName = namer.instanceMethodName(methodName, arity);
- generateMethod(methodName.stringValue, jsName, arity);
+ String jsName =
+ namer.instanceMethodInvocationName(methodName, selector);
+ generateMethod(methodName.stringValue, jsName, selector);
}
}
});
compiler.universe.invokedGetters.forEach((SourceString getterName) {
String jsName = namer.getterName(getterName);
- generateMethod('get $getterName', jsName, 0);
+ generateMethod('get $getterName', jsName, Selector.GETTER);
});
compiler.universe.invokedSetters.forEach((SourceString setterName) {
String jsName = namer.setterName(setterName);
- generateMethod('set $setterName', jsName, 1);
+ generateMethod('set $setterName', jsName, Selector.SETTER);
});
}
« no previous file with comments | « no previous file | tests/language/language-leg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698