Support noSuchMethod for methods that take named parameters.

frog/leg/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Generates the code for all used classes in the program. Static fields (even
  * in classes) are ignored, since they can be treated as non-class elements.
  *
  * The code for the containing (used) methods must exist in the [:universe:].
  */
@@ skipping 283 matching lines @@
     // TODO(ngeoffray): We don't need to generate these methods if
     // nobody overwrites noSuchMethod.
 
     ClassElement objectClass =
         compiler.coreLibrary.find(const SourceString('Object'));
     String className = namer.isolatePropertyAccess(objectClass);
     String prototype = '$className.prototype';
     String noSuchMethodName =
         namer.instanceMethodName(Compiler.NO_SUCH_METHOD, 2);
 
-    void generateMethod(String methodName, String jsName, int arity) {
+    void generateMethod(String methodName, String jsName, Selector selector) {
       buffer.add('$prototype.$jsName = function');
       StringBuffer args = new StringBuffer();
-      for (int i = 0; i < arity; i++) {
+      for (int i = 0; i < selector.argumentCount; i++) {
         if (i != 0) args.add(', ');
         args.add('arg$i');
       }
       buffer.add(' ($args) {\n');
       buffer.add("  return this.$noSuchMethodName('$methodName', [$args]);\n");

[floitsch, 2012/02/03 13:24:26]

in the current form NSM is useless since you wouldn't know what named argument
got what value. correct?

[ngeoffray, 2012/02/03 13:42:27]

Correct, we need to implement a mirror thingy...

       buffer.add('}\n');
     }
 
     compiler.universe.invokedNames.forEach((SourceString methodName,
                                             Set<Selector> selectors) {
       if (objectClass.lookupLocalMember(methodName) === null
           && methodName != Namer.OPERATOR_EQUALS) {
         for (Selector selector in selectors) {
-          int arity = selector.argumentCount;
-          String jsName = namer.instanceMethodName(methodName, arity);
-          generateMethod(methodName.stringValue, jsName, arity);
+          String jsName =
+              namer.instanceMethodInvocationName(methodName, selector);
+          generateMethod(methodName.stringValue, jsName, selector);
         }
       }
     });
 
     compiler.universe.invokedGetters.forEach((SourceString getterName) {
       String jsName = namer.getterName(getterName);
-      generateMethod('get $getterName', jsName, 0);
+      generateMethod('get $getterName', jsName, Selector.GETTER);
     });
 
     compiler.universe.invokedSetters.forEach((SourceString setterName) {
       String jsName = namer.setterName(setterName);
-      generateMethod('set $setterName', jsName, 1);
+      generateMethod('set $setterName', jsName, Selector.SETTER);
     });
   }
 
   String assembleProgram() {
     measure(() {
       StringBuffer buffer = new StringBuffer();
       buffer.add('function ${namer.ISOLATE}() {');
       emitStaticNonFinalFieldInitializations(buffer);
       buffer.add('}\n\n');
       emitClasses(buffer);
       emitNoSuchMethodCalls(buffer);
       emitStaticFunctions(buffer);
       emitStaticFinalFieldInitializations(buffer);
       buffer.add('var ${namer.CURRENT_ISOLATE} = new ${namer.ISOLATE}();\n');
       Element main = compiler.mainApp.find(Compiler.MAIN);
       buffer.add('${namer.isolateAccess(main)}();\n');
       compiler.assembledCode = buffer.toString();
     });
     return compiler.assembledCode;
   }
 }