Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 9325015: Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium) (Closed)

Created:
9 years, 1 month ago by abarth-chromium
Modified:
9 years, 1 month ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium) https://bugs.webkit.org/show_bug.cgi?id=77312 Reviewed by Dimitri Glazkov. When we autogenerated the event factory, we missed the check for whether touch events were enabled at runtime: http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp This patch adds the check back. Unfortunately, there isn't a testing frame work for RuntimeEnabledFeatures. The main difficulty is that these static bools need to be set when WebKit is initialized and can't be changed (which is why they're not part of WebCore::Settings). To test them properly, we'd need a testing framework that booted up WebKit for each test. We could test this particular change (which doesn't need the bool to be constant through the runtime of WebKit), but that would create a sandtrap for future patches who might thing that this testing framework can really be used to test RuntimeEnabledFeatures. The net result is that Chromium is going to end up living with the non-default codepath for these settings being untested, which will lead to regressions like this one. If we ened up with a bunch of these regressions, we'll likely end up with a testing framework similar to Chromium's browsers_tests, which create a fresh subprocess for each test. * dom/EventFactory.in: * dom/make_event_factory.pl: (defaultItemFactory): (generateImplementation): TBR=abarth@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=106604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M Source/WebCore/dom/EventFactory.in View 1 chunk +1 line, -2 lines 0 comments Download
M Source/WebCore/dom/make_event_factory.pl View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
abarth-chromium
9 years, 1 month ago (2012-02-03 00:47:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698