Issue 9323079: Enable non-incremental code compaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9323079: Enable non-incremental code compaction. (Closed)

Created:
8 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 10 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enable non-incremental code compaction. It is intended to bring memory usage down on idle notifications. R=erik.corry@gmail.com BUG=v8:1726 Committed: https://code.google.com/p/v8/source/detail?r=10616

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/incremental-marking.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/mark-compact.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View	2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

8 years, 10 months ago (2012-02-07 08:12:58 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9323079/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

https://chromiumcodereview.appspot.com/9323079/diff/1/src/incremental-marking...
src/incremental-marking.cc:508:
heap_->mark_compact_collector()->StartCompaction(true);
If we are going to have boolean arguments we should at least have a comment on
the call site to say what it means.

https://chromiumcodereview.appspot.com/9323079/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/9323079/diff/1/src/mark-compact.cc#new...
src/mark-compact.cc:252: if (!incremental) {
Please reverse the sense and order of this if.

Expand Messages | Collapse Messages