uber extensions

uber extensions

change trash to be a button so that clicking it doesn't focus it (as I recently discovered).

the problem described in the bug stems from the fact that clicking the div focuses it, and a focused trash icon is visible and open (to support keyboard usage).

BUG=112496
TEST=see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120674

[Dan Beam, 2012-02-04 02:18:04]

lgtm w/suggestion

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/css/trash.css (right):

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/css/trash.css:13: padding: none;
padding: 0; just to match other occurrences ("padding: none;" -> 0 occurrences,
http://code.google.com/p/chromium/source/search?q=%22padding%3A+none%3B%22,
"padding: 0;" -> 44 occurrences,
http://code.google.com/p/chromium/source/search?q=%22padding%3A+0%3B%22+chrom...)

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/html/trash.html (right):

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/html/trash.html:1: <button class="trash
custom-appearance" tabindex="0">
if you remove the tabindex from the <div> it won't focus on click, but you'd
also not be able to tab to it, so I guess this is aight

[Evan Stade, 2012-02-04 02:35:49]

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/css/trash.css (right):

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/css/trash.css:13: padding: none;
On 2012/02/04 02:18:04, Dan Beam wrote:
> padding: 0; just to match other occurrences ("padding: none;" -> 0
occurrences,
>
http://code.google.com/p/chromium/source/search?q=%2522padding%253A+none%253B...,
> "padding: 0;" -> 44 occurrences,
>
http://code.google.com/p/chromium/source/search?q=%2522padding%253A+0%253B%25...)

I think I actually like padding: none better, although I never thought about it
before. However I'll go with the flow.

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/html/trash.html (right):

http://codereview.chromium.org/9323052/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/html/trash.html:1: <button class="trash
custom-appearance" tabindex="0">
On 2012/02/04 02:18:04, Dan Beam wrote:
> if you remove the tabindex from the <div> it won't focus on click, but you'd
> also not be able to tab to it, so I guess this is aight

actually I guess now that it's a button i don't need tabindex="0"

[commit-bot: I haz the power, 2012-02-04 03:39:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/9323052/3003

[commit-bot: I haz the power, 2012-02-04 06:00:18]

Try job failure for 9323052-3003 (retry) on mac_rel for step "net_unittests".
It's a second try, previously, steps "base_unittests, net_unittests,
browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...