Update sizes.py to print a list of all static initializers

build/scripts/slave/chromium/sizes.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A tool to extract size information for chrome, executed by buildbot.
 
   When this is run, the current directory (cwd) should be the outer build
   directory (e.g., chrome-release/build/).
 
@@ skipping 107 matching lines @@
 RESULT %(app_bundle)s: %(app_bundle)s= %(app_bundle_size)s bytes
 RESULT chrome-si: initializers= %(initializers)d files
 """) % (
         print_dict)
       # Found a match, don't check the other base_names.
       return result
   # If no base_names matched, fail script.
   return 66
 
 
-def check_linux_binary(target_dir, binary_name):
+def check_linux_binary(target_dir, binary_name, options):
   """Collect appropriate size information about the built Linux binary given.
 
   Returns a tuple (result, sizes).  result is the first non-zero exit
   status of any command it executes, or zero on success.  sizes is a list
   of tuples (name, identifier, totals_identifier, value, units).
   The printed line looks like:
     name: identifier= value units
   When this same data is used for totals across all the binaries, then
   totals_identifier is the identifier to use, or '' to just use identifier.
   """
@@ skipping 19 matching lines @@
                 get_size(binary_file), 'bytes'))
 
   result, stdout = run_process(result, ['size', binary_file])
   text, data, bss = re.search('(\d+)\s+(\d+)\s+(\d+)', stdout).groups()
   sizes += [
       (binary_name + '-text', 'text', '', text, 'bytes'),
       (binary_name + '-data', 'data', '', data, 'bytes'),
       (binary_name + '-bss', 'bss', '', bss, 'bytes'),
       ]
 
-  # Find the number of files with at least one static initializer.
-  # First determine if we're 32 or 64 bit
-  result, stdout = run_process(result, ['readelf', '-h', binary_file])
-  elf_class_line = re.search('Class:.*$', stdout, re.MULTILINE).group(0)
-  elf_class = re.split('\W+', elf_class_line)[1]
-  if elf_class == 'ELF32':
-    word_size = 4
-  else:
-    word_size = 8
-
-  # Then find the size of the .ctors section.
-  result, stdout = run_process(result, ['readelf', '-SW', binary_file])
-  size_match = re.search('.ctors.*$', stdout, re.MULTILINE)
-  if size_match is None:
-    count = 0
-  else:
-    size_line = re.search('.ctors.*$', stdout, re.MULTILINE).group(0)
-    size = re.split('\W+', size_line)[5]
-    size = int(size, 16)
-    # The first entry is always 0 and the last is -1 as guards.
-    # So subtract 2 from the count.
-    count = (size / word_size) - 2
-  sizes.append((binary_name + '-si', 'initializers', '', count, 'files'))
+  # For Release builds only, use dump-static-initializers.py to get the number
+  # of static initializers.
+  if options.target == 'Release':
+    dump_static_initializers = os.path.join(os.path.dirname(target_dir),

[Lei Zhang, 2012/02/04 03:10:00]

So how about os.path.join(options.build_dir, 'tools', 'linux', d-s-i.py') ?

+                                            '..', '..', 'tools', 'linux',
+                                            'dump-static-initializers.py')
+    result, stdout = run_process(result, [dump_static_initializers,
+                                          '-d', binary_file])
+    count = re.search('Found (\d+) static initializers',
+                      stdout).group(1)
+    if count is not '0':
+      print '\nStatic initializers in %s:' % binary_file
+      print stdout
+    sizes.append(
+        (binary_name + '-si', 'initializers', '', count, 'initializers'))
 
   # Determine if the binary has the DT_TEXTREL marker.
   result, stdout = run_process(result, ['readelf', '-Wd', binary_file])
   if re.search(r'\bTEXTREL\b', stdout) is None:
     # Nope, so the count is zero.
     count = 0
   else:
     # There are some, so count them.
     result, stdout = run_process(result, ['eu-findtextrel', binary_file])
     count = stdout.count('\n')
@@ skipping 19 matching lines @@
       'libgcflashplayer.so',
       'libpdf.so',
       'libppGoogleNaClPluginChrome.so',
   ]
 
   result = 0
 
   totals = {}
 
   for binary in binaries:
-    this_result, this_sizes = check_linux_binary(target_dir, binary)
+    this_result, this_sizes = check_linux_binary(target_dir, binary, options)
     if result == 0:
       result = this_result
     for name, identifier, totals_id, value, units in this_sizes:
       print 'RESULT %s: %s= %s %s' % (name, identifier, value, units)
       totals_id = totals_id or identifier, units
       totals[totals_id] = totals.get(totals_id, 0) + int(value)
 
   files = [
     'chrome.pak',
     'nacl_irt_x86_64.nexe',
@@ skipping 87 matching lines @@
     else:
       sys.stderr.write('Unknown platform %s.\n' % repr(options.platform))
     msg = 'Use the --platform= option to specify a supported platform:\n'
     sys.stderr.write(msg + '    ' + ' '.join(platforms) + '\n')
     return 2
   return real_main(options, args)
 
 
 if '__main__' == __name__:
   sys.exit(main())