Update sizes.py to print a list of all static initializers

build/scripts/slave/chromium/sizes.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A tool to extract size information for chrome, executed by buildbot.
 
   When this is run, the current directory (cwd) should be the outer build
   directory (e.g., chrome-release/build/).
 
@@ skipping 147 matching lines @@
                 get_size(binary_file), 'bytes'))
 
   result, stdout = run_process(result, ['size', binary_file])
   text, data, bss = re.search('(\d+)\s+(\d+)\s+(\d+)', stdout).groups()
   sizes += [
       (binary_name + '-text', 'text', '', text, 'bytes'),
       (binary_name + '-data', 'data', '', data, 'bytes'),
       (binary_name + '-bss', 'bss', '', bss, 'bytes'),
       ]
 
-  # Find the number of files with at least one static initializer.
-  # First determine if we're 32 or 64 bit
-  result, stdout = run_process(result, ['readelf', '-h', binary_file])
-  elf_class_line = re.search('Class:.*$', stdout, re.MULTILINE).group(0)
-  elf_class = re.split('\W+', elf_class_line)[1]
-  if elf_class == 'ELF32':
-    word_size = 4
-  else:
-    word_size = 8
-
-  # Then find the size of the .ctors section.
-  result, stdout = run_process(result, ['readelf', '-SW', binary_file])
-  size_match = re.search('.ctors.*$', stdout, re.MULTILINE)
-  if size_match is None:
-    count = 0
-  else:
-    size_line = re.search('.ctors.*$', stdout, re.MULTILINE).group(0)
-    size = re.split('\W+', size_line)[5]
-    size = int(size, 16)
-    # The first entry is always 0 and the last is -1 as guards.
-    # So subtract 2 from the count.
-    count = (size / word_size) - 2
-  sizes.append((binary_name + '-si', 'initializers', '', count, 'files'))
+  # For Release builds only, use dump-static-initializers.py to get the number
+  # of static initializers.
+  if 'Release' in target_dir:

[Lei Zhang, 2012/02/03 22:54:57]

Otherwise, maybe os.path.basename(target_dir) is more robust?

Alternatively, if we had access to |options|, we can just check
|options.target|, and use options.build_dir below.

[Tyler Breisacher (Chromium), 2012/02/04 03:03:19]

You're right, that's probably cleaner.

+    dump_static_initializers = os.path.join(os.path.dirname(target_dir),

[Lei Zhang, 2012/02/03 22:54:57]

If |target_dir| is /path/to/src/out/Release, don't we need
'../../tools/linux/d-s-i.py' ?

[Tyler Breisacher (Chromium), 2012/02/04 03:03:19]

I think you're right.

+                                            '..', 'tools', 'linux',
+                                            'dump-static-initializers.py')
+    result, stdout = run_process(result, [dump_static_initializers,
+                                          '-d', binary_file])
+    count = re.search('Found (\d+) static initializers',
+                      stdout).group(1)
+    if count is not '0':
+      print '\nStatic initializers in %s:' % binary_file
+      print stdout
+    sizes.append(
+        (binary_name + '-si', 'initializers', '', count, 'initializers'))
 
   # Determine if the binary has the DT_TEXTREL marker.
   result, stdout = run_process(result, ['readelf', '-Wd', binary_file])
   if re.search(r'\bTEXTREL\b', stdout) is None:
     # Nope, so the count is zero.
     count = 0
   else:
     # There are some, so count them.
     result, stdout = run_process(result, ['eu-findtextrel', binary_file])
     count = stdout.count('\n')
@@ skipping 127 matching lines @@
     else:
       sys.stderr.write('Unknown platform %s.\n' % repr(options.platform))
     msg = 'Use the --platform= option to specify a supported platform:\n'
     sys.stderr.write(msg + '    ' + ' '.join(platforms) + '\n')
     return 2
   return real_main(options, args)
 
 
 if '__main__' == __name__:
   sys.exit(main())