Issue 9323045: Suppress all reports from waterfall_drmem.sh.

Issue 9323045: Suppress all reports from waterfall_drmem.sh. (Closed)

Created:
8 years, 10 months ago by Reid Kleckner

Modified:
8 years, 10 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Suppress all reports from waterfall_drmem.sh. Also fix test_suppressions.py for drmemory bots, which also match "Windows%20". R=timurrrr@chromium.org BUG=74417, 32624 TEST=waterfall_drmem.sh Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121243

Patch Set 2 : Drop suppression for leak I fixed in separate CL. #

Total comments: 4

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -18 lines)			Patch
	M	tools/valgrind/drmemory/suppressions_full.txt	View	1	7 chunks	+86 lines, -15 lines	4 comments	Download
	M	tools/valgrind/test_suppressions.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM with one nit Sorry for making the review so slow... https://chromiumcodereview.appspot.com/9323045/diff/4/tools/valgrind/drmemory/suppressions_full.txt File tools/valgrind/drmemory/suppressions_full.txt (right): ...

8 years, 10 months ago (2012-02-09 10:50:18 UTC) #2

Reid Kleckner

8 years, 10 months ago (2012-02-09 15:17:36 UTC) #3

https://chromiumcodereview.appspot.com/9323045/diff/4/tools/valgrind/drmemory...
File tools/valgrind/drmemory/suppressions_full.txt (right):

https://chromiumcodereview.appspot.com/9323045/diff/4/tools/valgrind/drmemory...
tools/valgrind/drmemory/suppressions_full.txt:358:
name=http://code.google.com/p/drmemory/issues/detail?id=712 h
On 2012/02/09 10:50:18, Timur Iskhodzhanov wrote:
> I prefer to sort the issues by their IDs.
> Why "h" ?

Should be issue 412, and h follows g.

https://chromiumcodereview.appspot.com/9323045/diff/4/tools/valgrind/drmemory...
tools/valgrind/drmemory/suppressions_full.txt:992: name=http://crbug.com/32624
On 2012/02/09 10:50:18, Timur Iskhodzhanov wrote:
> Might be worth filing a separate bug if you believe there should be a root.

Yeah, I think there's some underlying issue.  You can search up and down this
file and in drmem's supps and see a bunch of tls related supps.  Created 778 to
cover this.

Expand Messages | Collapse Messages