Chromium Code Reviews

Issue 9323038: Work around 32-bit Linux userlands. (Closed)

Created:
8 years, 10 months ago by Evan Martin
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Work around 32-bit Linux userlands. - Move the gold binary to "gold64". - Make "ld" a script that tests the userland bitness and executes the appropriate helper. TEST=gold/ld --version is gold on my machine, but bfd linker when I corrupt the string the script searches for. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120368

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+-1 lines, --1 lines)
A + gold64 View 0 chunks +-1 lines, --1 lines 0 comments

Messages

Total messages: 4 (0 generated)
Evan Martin
Can use getconf if you think that's more sensible (wrote this before I saw your ...
8 years, 10 months ago (2012-02-03 19:42:56 UTC) #1
Evan Martin
crap, rietveld can't show the new script (because it attempts to diff it against the ...
8 years, 10 months ago (2012-02-03 19:43:37 UTC) #2
Nico
ld script missing from cl
8 years, 10 months ago (2012-02-03 19:43:45 UTC) #3
Nico
8 years, 10 months ago (2012-02-03 19:45:35 UTC) #4
LGTM, but LEBTM if you add a todo to check in a 32bit gold. Else 32bit builds
will fail in magical ways soon. (Or state that building on 32bit linuxens isn't
supported and ask infra to upgrade that bot, probably better.)

But this is ok temporarily.

Powered by Google App Engine