Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 9323031: Fix flakiness in Chrome Frame HeaderTest. (Closed)

Created:
8 years, 10 months ago by grt (UTC plus 2)
Modified:
8 years, 10 months ago
CC:
chromium-reviews, amit, robertshield
Visibility:
Public.

Description

Fix flakiness in Chrome Frame HeaderTest. Responses were being cached by IE, so there was a reasonable probability that two permutations used the same URL. This change adds a no-cache header so the URL doesn't matter. BUG=99235 TEST=none -- covered by chrome_frame_tests.exe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120336

Patch Set 1 #

Patch Set 2 : copyright year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome_frame/test/header_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
grt (UTC plus 2)
8 years, 10 months ago (2012-02-03 15:54:20 UTC) #1
erikwright (departed)
8 years, 10 months ago (2012-02-03 15:56:52 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698