[WebUI] Add some presubmit checks

chrome/browser/resources/PRESUBMIT.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Presubmit script for Chromium WebUI resources.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into gcl/git cl, and see
+http://www.chromium.org/developers/web-development-style-guide for the rules
+we're checking against here.
+"""
+
+
+def CheckChangeOnUpload(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+  return _CommonChecks(input_api, output_api)
+
+
+def _CommonChecks(input_api, output_api):
+  """Checks common to both upload and commit."""
+  results = []
+  resources = input_api.PresubmitLocalPath()
+
+  path = input_api.os_path
+  presubmit = path.join(resources, 'PRESUBMIT.py')
+  if presubmit in [f.AbsoluteLocalPath() for f in input_api.AffectedFiles()]:

[M-A Ruel, 2012/02/09 22:14:14]

if presubmit in (f.AbsoluteLocalPath() for f in input_api.AffectedFiles()):

is marginally better.
I would have preferred looking for LocalPath() but I'm not sure there's a good
way to calculate that. :/

[Dan Beam, 2012/02/14 17:02:01]

Done. (list -> tuple)
I think you saw why it's hard-ish to do that from tbreisacher's code, yeah?

[M-A Ruel, 2012/02/14 17:15:19]

You are confusing tuple and generators. This is a generator, not a tuple. And
yes this is confusing that both are using parenthesis.

[Dan Beam, 2012/02/14 17:48:46]

See updated code (and tell me if it's still wrong).

+    tests = [path.join(resources, 'test_presubmit.py')]
+    results.extend(
+        input_api.canned_checks.RunUnitTests(input_api, output_api, tests))
+
+  import sys
+  old_sys_path = sys.path
+  try:
+    from web_dev_style import css_checker
+  except ImportError:
+    sys.path.append(resources)

[M-A Ruel, 2012/02/09 22:14:14]

sys.path.insert(0, resources)

[Dan Beam, 2012/02/14 17:02:01]

Done.

+    from web_dev_style import css_checker
+  finally:
+    sys.path = old_sys_path
+
+  # TODO(dbeam): Remove this filter eventually when ready.
+  def file_filter(affected_file):
+    dirs = (path.join(resources, 'ntp4'), path.join(resources, 'options2'))
+    f = affected_file.AbsoluteLocalPath()
+    return (f.startswith(dirs) and f.endswith('.css'))
+
+  results.extend(css_checker.CSSChecker(input_api, output_api,
+                                        file_filter=file_filter).RunChecks())
+  return results