Issue 9323004: ARM: More micro-optimization of megamorphic lookup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9323004: ARM: More micro-optimization of megamorphic lookup. (Closed)

Created:
8 years, 10 months ago by Erik Corry

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

ARM: More micro-optimization of megamorphic lookup. Committed: https://code.google.com/p/v8/source/detail?r=10599

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/arm/stub-cache-arm.cc	View	1 2	3 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://chromiumcodereview.appspot.com/9323004/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/9323004/diff/1/src/arm/stub-cache-arm.cc#newcode224 src/arm/stub-cache-arm.cc:224: __ rsb(scratch, name, Operand(scratch, LSL, 1)); One of these ...

8 years, 10 months ago (2012-02-02 15:23:42 UTC) #2

Michael Starzinger

LGTM. https://chromiumcodereview.appspot.com/9323004/diff/2002/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/9323004/diff/2002/src/arm/stub-cache-arm.cc#newcode223 src/arm/stub-cache-arm.cc:223: // Primary miss: Compute hash for secondary probe. ...

8 years, 10 months ago (2012-02-02 15:36:07 UTC) #3

New version uploaded.

Expand Messages | Collapse Messages

Issue 9323004: ARM: More micro-optimization of megamorphic lookup. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages